[pkgsrc/trunk]: pkgsrc/mk/compiler mk/compiler/gfortran.mk: Add comment about...

[gdt <gdt%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/6bd916b7e08f
branches:  trunk
changeset: 414374:6bd916b7e08f
user:      gdt <gdt%pkgsrc.org@localhost>
date:      Thu Mar 26 12:44:46 2020 +0000

description:
mk/compiler/gfortran.mk: Add comment about gcc 4.8 handling

The code maps gcc-4.8.x to "4", and then won't find gcc4.  This is a
bug, but it may be that it's just as well to never match 4.X of any
kind, and use 7 anyway.   Explain this issue with a \todo to fix the
bug or document the consequences as intended.

(This is a comment-only change.)

diffstat:

 mk/compiler/gfortran.mk |  5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diffs (19 lines):

diff -r ee45d94d1026 -r 6bd916b7e08f mk/compiler/gfortran.mk
--- a/mk/compiler/gfortran.mk   Thu Mar 26 12:42:02 2020 +0000
+++ b/mk/compiler/gfortran.mk   Thu Mar 26 12:44:46 2020 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: gfortran.mk,v 1.14 2020/03/26 12:42:02 gdt Exp $
+# $NetBSD: gfortran.mk,v 1.15 2020/03/26 12:44:46 gdt Exp $
 #
 # Copyright (c) 2005 The NetBSD Foundation, Inc.
 # All rights reserved.
@@ -36,6 +36,9 @@
 # If pkgsrc base compiler is GCC, match the gfortran requirement as closely as
 # possible.  Otherwise, default to a mainstream version and hope for the best.
 # If base compiler is clang, we really should use flang rather than gfortran.
+# \todo Perhaps adjust this so that gcc-4.8.3 maps to 48, or document that 4.8
+# is so old that we intend what seems like a bug to choose the modern version
+# in that case.
 POSSIBLE_GFORTRAN_VERSION?=    ${CC_VERSION:S/gcc-//:C/.[0-9].[0-9]$//}
 
 .if !empty(PKGSRC_COMPILER:Mgcc) && \