[pkgsrc/trunk]: pkgsrc/pkgtools/pkglint4 pkgtools/pkglint4: update to 4.193.2

[rillig <rillig%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/189024baf839
branches:  trunk
changeset: 417921:189024baf839
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Mon Nov 18 08:06:58 2019 +0000

description:
pkgtools/pkglint4: update to 4.193.2

Changes since 4.193.1:

Disabled unreliable check about possible typos in variable names. For
example, in pkgtools/url2pkg the variable TEST_DEPENDS was flagged even
though it is well-known.

Disabled unreliable check about unknown shell commands. For example, in
pkgtools/pkglint4 all commands from ${PREFIX} are ok, but were still
flagged.

diffstat:

 pkgtools/pkglint4/Makefile               |  4 ++--
 pkgtools/pkglint4/files/PkgLint/Shell.pm |  6 +++---
 pkgtools/pkglint4/files/pkglint.pl       |  6 +++---
 3 files changed, 8 insertions(+), 8 deletions(-)

diffs (60 lines):

diff -r d4e23a65e371 -r 189024baf839 pkgtools/pkglint4/Makefile
--- a/pkgtools/pkglint4/Makefile        Mon Nov 18 08:02:15 2019 +0000
+++ b/pkgtools/pkglint4/Makefile        Mon Nov 18 08:06:58 2019 +0000
@@ -1,6 +1,6 @@
-# $NetBSD: Makefile,v 1.14 2019/11/17 02:54:10 rillig Exp $
+# $NetBSD: Makefile,v 1.15 2019/11/18 08:06:58 rillig Exp $
 
-PKGNAME=       pkglint4-4.193.1
+PKGNAME=       pkglint4-4.193.2
 CATEGORIES=    pkgtools
 
 OWNER=         rillig%NetBSD.org@localhost
diff -r d4e23a65e371 -r 189024baf839 pkgtools/pkglint4/files/PkgLint/Shell.pm
--- a/pkgtools/pkglint4/files/PkgLint/Shell.pm  Mon Nov 18 08:02:15 2019 +0000
+++ b/pkgtools/pkglint4/files/PkgLint/Shell.pm  Mon Nov 18 08:06:58 2019 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Shell.pm,v 1.3 2019/10/06 11:06:42 rillig Exp $
+# $NetBSD: Shell.pm,v 1.4 2019/11/18 08:06:59 rillig Exp $
 #
 # Parsing and checking shell commands embedded in Makefiles
 #
@@ -524,8 +524,8 @@
                                }
 
                        } else {
-                               $opt_warn_extra and $line->log_warning("Unknown shell command \"${shellword}\".");
-                               $opt_warn_extra and $line->explain_warning(
+                               0 and $opt_warn_extra and $line->log_warning("Unknown shell command \"${shellword}\".");
+                               0 and $opt_warn_extra and $line->explain_warning(
 "If you want your package to be portable to all platforms that pkgsrc",
 "supports, you should only use shell commands that are covered by the",
 "tools framework.");
diff -r d4e23a65e371 -r 189024baf839 pkgtools/pkglint4/files/pkglint.pl
--- a/pkgtools/pkglint4/files/pkglint.pl        Mon Nov 18 08:02:15 2019 +0000
+++ b/pkgtools/pkglint4/files/pkglint.pl        Mon Nov 18 08:06:58 2019 +0000
@@ -1,5 +1,5 @@
 #! @PERL@
-# $NetBSD: pkglint.pl,v 1.10 2019/10/06 11:45:05 rillig Exp $
+# $NetBSD: pkglint.pl,v 1.11 2019/11/18 08:06:58 rillig Exp $
 #
 
 # pkglint - static analyzer and checker for pkgsrc packages
@@ -2249,7 +2249,7 @@
                # Variables defined in .for loops are also ok.
 
        } else {
-               $opt_warn_extra and $line->log_warning("${varname} is used but not defined. Spelling mistake?");
+               0 and $opt_warn_extra and $line->log_warning("${varname} is used but not defined. Spelling mistake?");
        }
 
        if ($varname eq "LOCALBASE" && !$is_internal) {
@@ -3362,7 +3362,7 @@
                } elsif (exists($deprecated->{$varname}) || exists($deprecated->{$varcanon})) {
                        # Ok
                } else {
-                       $line->log_warning("${varname} is defined but not used. Spelling mistake?");
+                       0 and $line->log_warning("${varname} is defined but not used. Spelling mistake?");
                }
        }