[pkgsrc/trunk]: pkgsrc/ham/xnec2c (ham/xnec2c) Updated 3.5.1 to 4.1.5

[mef <mef%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/b9d6090492f4
branches:  trunk
changeset: 457091:b9d6090492f4
user:      mef <mef%pkgsrc.org@localhost>
date:      Mon Aug 16 13:43:49 2021 +0000

description:
(ham/xnec2c) Updated 3.5.1 to 4.1.5

(doc/xnec2.html)

Version 3.6-beta: I migrated Xnec2c to the latest GTK+-3.22 toolkit to bring it
up to date. A lot of changes were needed to both the GUI and parts of the
Xnec2c source code, mainly the use of GTK3's GUI Builder for creating the User
Interface and the revised drawing model of GDK for presenting the Graphics
displays. A new autogen.sh script has also been incorporated in the source
package and internationalization has been migrated to the GNU GetText system.
Because Xnec2c is very complicated and thorough testing is difficult, I am
releasing this version as a beta.

Version 3.6.1-beta: After a request by Don Walters W9DKI I modified the
xnec2c.glade file to reduce the default size of the drawing areas as they would
not fit in displays with reduced resolution. I also removed some legacy code,
left over from the migration of xnec2c to GTK3, which was producing error
messages from GTK3 during the dragging of structure or radiation pattern
displays. And I modified the Makefile.am file to get "make install" to install
program files and documentation to the right places.

Version 3.7-beta: After some feature requests by users of xnec2c, I implemented
a number of changes to xnec2c so that it can save the state of the GUI at exit
and restore it on start up. To this effect xnec2c now produces a configuration
file xnec2c.config in the user's ~/.config directory. In this file xnec2c saves
the state (position, size, active toggle buttons, projection parameters for
structure and radiation pattern displays, the state of the frequency loop etc)
of the main windows, e.g. structure, radiation pattern, frequency plots and
NEC2 editor.
I have also added keyboard accelerators for a number of buttons and menu items,
more commonly used in the main windows of xnec2c, and a new "Zo" NEC2 "card" to
specify transmission line impedance.

Version 3.7.1-beta: Fixed a reported bug that prevented wire diameter entries
less than 0.01 in the Helix (GH) card editor. This was due to specifying a
minimum value of 0.01 in the xnec2c.glade file.

Version 3.8-beta: I edited some of the code so that when a NEC2 file is saved,
the Center x and y offsets (the change of position) of the structure and
radiation pattern are not changed. I also arranged for the offset values to be
saved in ~/.config/xnec2c.config when closing xnec2c, and to be read back and
restored when starting.

Version 3.9-beta: I have arranged for some user actions to be "nested", mainly
regarding the saving of NEC2 editor data followed by the opening of another
file or starting a new project. Some such functionality already existed in
previous versions but it is now more comprehensive.
Another useful change is fixing a bug in the original NEC2 code for producing a
helix (as specified by the GH "card"). This bug resulted a division by zero if
the helix length was specified as zero, possibly intended to produce a spiral.
The GH card can now be used to produce both a helix or a spiral with no
floating point exceptions.

Version 3.9: Since I have not received any bug reports for some time after
releasing version 3.9-b, and having fixed a bug that resulted in a
gtk_widget_destroy() command to be passed on an invalid widget pointer, I am
releasing xnec2c as version 3.9.

Version 4.0: I have changed the code that saves the state of the
View-Polarization menu items, as it would only correctly save the state of
these items in the Main (structure) window. I also changed the code that
handles the removal of "card" entries in the NEC2 editor, as it was causing
crashes of xnec2c under some user action combinations.

Version 4.0: I corrected some mistakes in the GUI interface code, which handles
the creation of windows and dialogs from the glade UI description file. These
mistakes were such that they did not effect the operation of xnec2c but in any
case I fixed them for the sake of correct programming. Also changed the wire
designer dialog to include the Tapered Wire selection check-button in the
dialog's frame and the relevant code to deal with this better.

Version 4.1: I corrected some mistakes in the GUI interface code, which handles
the creation of windows and dialogs from the glade UI description file. These
mistakes were such that they did not effect the operation of xnec2c but in any
case I fixed them for the sake of correct programming. Also changed the wire
designer dialog to include the Tapered Wire selection check-button in the
dialog's frame and the relevant code to deal with this better.

Version 4.1.1: I made a small change to the Radiation Pattern code to allow the
drawing of both horizontal an vertical "cuts" in the radiation pattern, in the
zx and zy vertical planes and the xy horizontal plane. Also changed the
accelerator keys for the Add, Remove, Clear, Save As, Save and Revert buttons
to be Modified by the Control button as the original accelerator keys were
being activated when writing in the Comments Treeview.

Version 4.1.2: Changed the installation commands in Makefile.am so that all the
relevant files (desktop file, application pixmap, configuration file,
executable binary etc) are installed under any location specified to the
configure script by the --prefix= option. Also modified the program so that on
first start up after installation, the application will create its working
directory by copying files from the relevant directories under the installation
prefix.

Version 4.1.3: Arranged the pipe reading function for the parent process to
re-read from the child processes if not all data is transferred at the first
read(). In this case xnec2c was crushing with "Resource temporarily
unavailable" error message.

Version 4.1.4: Added the stdint.h include file to common.h to fix a compilation
error reported by Nick G3VNC.

Version 4.1.5: After an inquiry by Eric Wheeler KJ7LNW regarding the use of the
GH card to create spirals, I found a bug that caused the GH editor to delete
the GH entry in NEC2 Editor's treeview. I also found a bug that caused the
number of turns of a spiral to be rounded to the nearest integer. Both bugs
have been fixed in this version.

diffstat:

 ham/xnec2c/Makefile                      |   7 +++----
 ham/xnec2c/PLIST                         |  10 ++++++++--
 ham/xnec2c/distinfo                      |  12 ++++++------
 ham/xnec2c/patches/patch-src_Makefile.in |  21 +++++++++++----------
 4 files changed, 28 insertions(+), 22 deletions(-)

diffs (92 lines):

diff -r 4b067500b974 -r b9d6090492f4 ham/xnec2c/Makefile
--- a/ham/xnec2c/Makefile       Mon Aug 16 13:28:47 2021 +0000
+++ b/ham/xnec2c/Makefile       Mon Aug 16 13:43:49 2021 +0000
@@ -1,7 +1,6 @@
-# $NetBSD: Makefile,v 1.25 2020/08/17 20:19:14 leot Exp $
+# $NetBSD: Makefile,v 1.26 2021/08/16 13:43:49 mef Exp $
 
-DISTNAME=      xnec2c-3.5.1
-PKGREVISION=   10
+DISTNAME=      xnec2c-4.1.5
 CATEGORIES=    ham
 MASTER_SITES=  http://www.qsl.net/5b4az/pkg/nec2/xnec2c/
 EXTRACT_SUFX=  .tar.bz2
@@ -20,5 +19,5 @@
 post-install:
        cd ${WRKSRC}/doc && ${PAX} -pp -rw * ${DESTDIR}${PREFIX}/share/doc/xnec2c
 
-.include "../../x11/gtk2/buildlink3.mk"
+.include "../../x11/gtk3/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"
diff -r 4b067500b974 -r b9d6090492f4 ham/xnec2c/PLIST
--- a/ham/xnec2c/PLIST  Mon Aug 16 13:28:47 2021 +0000
+++ b/ham/xnec2c/PLIST  Mon Aug 16 13:43:49 2021 +0000
@@ -1,8 +1,9 @@
-@comment $NetBSD: PLIST,v 1.4 2016/07/14 11:59:06 mef Exp $
+@comment $NetBSD: PLIST,v 1.5 2021/08/16 13:43:49 mef Exp $
 bin/xnec2c
+man/man1/xnec2c.1
+share/applications/xnec2c.desktop
 share/doc/xnec2c/NEC2-bug.txt
 share/doc/xnec2c/NearFieldCalcs.txt
-share/doc/xnec2c/images/charges.png
 share/doc/xnec2c/images/currents.png
 share/doc/xnec2c/images/excitation.png
 share/doc/xnec2c/images/freq_plots.png
@@ -12,3 +13,8 @@
 share/doc/xnec2c/nec2c.txt
 share/doc/xnec2c/xnec2c.1.gz
 share/doc/xnec2c/xnec2c.html
+share/examples/xnec2c/link.svg
+share/examples/xnec2c/unlink.svg
+share/examples/xnec2c/xnec2c.glade
+share/examples/xnec2c/xnec2c.svg
+share/pixmaps/xnec2c.svg
diff -r 4b067500b974 -r b9d6090492f4 ham/xnec2c/distinfo
--- a/ham/xnec2c/distinfo       Mon Aug 16 13:28:47 2021 +0000
+++ b/ham/xnec2c/distinfo       Mon Aug 16 13:43:49 2021 +0000
@@ -1,7 +1,7 @@
-$NetBSD: distinfo,v 1.10 2018/02/02 10:37:44 jperkin Exp $
+$NetBSD: distinfo,v 1.11 2021/08/16 13:43:49 mef Exp $
 
-SHA1 (xnec2c-3.5.1.tar.bz2) = 3383d6a25fab873a10f703e26d8118399b0cac68
-RMD160 (xnec2c-3.5.1.tar.bz2) = f3499eb34841cefbf545e1ca89a97a4a39152d99
-SHA512 (xnec2c-3.5.1.tar.bz2) = 3ba4bbe9d013176ced4d5aa584cd1e4b55caeb193cd3ec905e460421ed21038ff44dea332a3aa0650c34df6ef6bf5a2a9cbf5da7c7ba892b82c2fe7e253d99f5
-Size (xnec2c-3.5.1.tar.bz2) = 995554 bytes
-SHA1 (patch-src_Makefile.in) = be365448762fd5e96b8df71713a455ab9bd50c8a
+SHA1 (xnec2c-4.1.5.tar.bz2) = 7474de3525abb921fb78e7b93bf5d80c222e376b
+RMD160 (xnec2c-4.1.5.tar.bz2) = c3d9dd85d4be26c79ca573d0f30b5c188e5c5fff
+SHA512 (xnec2c-4.1.5.tar.bz2) = aaf5d7d30dcbb5c78a93ee6baea8ab4a00e44231826ce54dc54ee10be9b989dc4d2be4c8c32671596dd8c84292cdcf10a6e547aac6b943cbff0904b22ffc1299
+Size (xnec2c-4.1.5.tar.bz2) = 936233 bytes
+SHA1 (patch-src_Makefile.in) = 4fde316b9074b29f59494c0ac43a0481f93d9f43
diff -r 4b067500b974 -r b9d6090492f4 ham/xnec2c/patches/patch-src_Makefile.in
--- a/ham/xnec2c/patches/patch-src_Makefile.in  Mon Aug 16 13:28:47 2021 +0000
+++ b/ham/xnec2c/patches/patch-src_Makefile.in  Mon Aug 16 13:43:49 2021 +0000
@@ -1,16 +1,17 @@
-$NetBSD: patch-src_Makefile.in,v 1.1 2018/02/02 10:37:44 jperkin Exp $
+$NetBSD: patch-src_Makefile.in,v 1.2 2021/08/16 13:43:49 mef Exp $
 
 Leave pkgsrc to handle security features.
 
---- src/Makefile.in.orig       2016-11-10 04:56:58.000000000 +0000
-+++ src/Makefile.in
-@@ -296,8 +296,7 @@ top_build_prefix = @top_build_prefix@
+--- src/Makefile.in.orig       2021-06-02 15:34:20.000000000 +0900
++++ src/Makefile.in    2021-08-16 22:31:52.404087618 +0900
+@@ -315,9 +315,7 @@ top_build_prefix = @top_build_prefix@
  top_builddir = @top_builddir@
  top_srcdir = @top_srcdir@
- AM_LDFLAGS = -Wl,--as-needed
--AM_CFLAGS = --pedantic -Wall -std=gnu99 -O2 -D_FORTIFY_SOURCE=2 \
--               -fstack-protector -Wformat -Werror=format-security -fpie
-+AM_CFLAGS = 
+ AM_LDFLAGS = -Wl,--export-dynamic -Wl,--as-needed
+-AM_CFLAGS = --pedantic -Wall -std=gnu11 -O2 -D_FORTIFY_SOURCE=2 \
+-            -fstack-protector-strong -Wformat -Werror=format-security -fpie \
+-            -DGTK_DISABLE_SINGLE_INCLUDES -DGDK_DISABLE_DEPRECATED \
++AM_CFLAGS = -DGTK_DISABLE_SINGLE_INCLUDES -DGDK_DISABLE_DEPRECATED \
+             -DGTK_DISABLE_DEPRECATED -DGSEAL_ENABLE \
+             -DGDK_PIXBUF_DISABLE_DEPRECATED -DG_DISABLE_DEPRECATED
  
- AM_CPPFLAGS = \
-       -DPROGRAMNAME_LOCALEDIR=\""$(PROGRAMNAME_LOCALEDIR)"\" \