On Wed, May 02, 2001 at 12:45:07AM -0400, Johnny C. Lam wrote:
> Jason Beegan <jtb@netbsd.org> writes:
> > 
> > Modified Files:
> > 	pkgsrc/graphics/geomview: Makefile
> > 
> > Log Message:
> > Use --with-opengl=${X11BASE} in CONFIGURE_ENV.
> 
> Isn't this incorrect if you are using XFree86 3.3.6 and have xpkgwedge
> installed?  Then the OpenGL headers from the Mesa package are
> installed into ${LOCALBASE}.  Perhaps we need something in bsd.pkg.mk
> or bsd.prefs.mk that sets MESADIR to the appropriate value depending
> on various factors:
> 
> 	XFree86-3.3.6               MESADIR=${X11BASE}
> 	XFree86-3.3.6 + xpkgwedge   MESADIR=${LOCALBASE}
> 	XFree86-4.0.1               MESADIR=${X11BASE}
> 	XFree86-4.0.1 + xpkgwedge   MESADIR=${X11BASE}
> 
> So, I guess something like:
> 
> 	.if ${HAVE_BUILTIN_MESA} != "NO"
> 	MESADIR=${X11BASE}
> 	.else
> 	MESADIR=${X11PREFIX}
> 	.endif
> 
> would work in bsd.pkg.mk.
> 
>      -- Johnny C. Lam <lamj@stat.cmu.edu>
>         Department of Statistics, Carnegie Mellon University
>         http://www.stat.cmu.edu/~lamj/

I'd prefer it if we did something like:

.if ${HAVE_BUILTIN_MESA} == "NO"
EVAL_PREFIX+=	MESA_DIR=Mesa
.else
MESA_DIR=	${X11BASE}
.endif

or even:

MESA_DIR_DEFAULT?=	${X11BASE}
EVAL_PREFIX+=		MESA_DIR=Mesa

That's the reason EVAL_PREFIX exists.

Regards,
Alistair