fredb@immanent.net (Frederick Bruckman) wrote:

Thomas> Why is this necessaty?

>> Possibly to make the MASTER_SITES of mozilla
>> customizable?

Frederick> There's a more natural way to do this. The
Frederick> japanese mirror isn't even one of MASTER_SITES of
Frederick> mozilla by default, so the casual user won't even
Frederick> know the capability is there.

A lot of numbers of site mirrers mozilla.  I don't want to
adding more ~70 lines to Makefile, do you?  It is same as
bsd.pkg.defaults.mk though, so I intended the value I added
to bsd.pkg.defaults.mk was an example.  I should have
mentioned that when I commit that.

Second, I'm afraid that adding .jp sites to MASTER_SITES of
default mk file makes some more traffic in other countries.

>> How about that all MASTER_SITES can be overrided by
>> MASTER_SITES.whatever?

Frederick> Not necessary. See the descriptions for
Frederick> MASTER_SORT and MASTER_SORT_REGEX in
Frederick> "bsd.pkg.defaults.mk". Moreover, I can't imagine
Frederick> anybody wanting to set a URI for every single
Frederick> package.  Can you? If it comes to that, the user
Frederick> can download into "distfiles" by
Frederick> hand. MASTER_SORT is way better, because it
Frederick> applies generally to all packages.

Does MASTER_SORT work even if the directory hierarchy are
different in between each mirror sites?  MASTER_SORT*
changes global behavior of the pkgsrc system as you said.  I
don't want that change, so decided to hack the Makefile of
mozilla package.  In this case, my point is the size of the
distribution.

Frederick> What you really want, I think, is accomplished by
Frederick> setting `MASTER_SORT=.jp' and adding the ".jp"
Frederick> mirrors to ${MASTER_SITES}. I don't see any
Frederick> reason why all known (working) mirrors shouldn't
Frederick> be added to MASTER_SITES, as the mirrors at the
Frederick> bottom of the list would rarely get hit unless
Frederick> the user sets MASTER_SORT or MASTER_SORT_REGEX
Frederick> anyway.

Simply adding mirror sites to Makefile or anywhere doesn't
provide flexibility to user.  Per-package based
customisability is not so bad thing to have, I guess.

Frederick> So, if japanese mirror is added to mozilla's
Frederick> MASTER_SITES, then MASTER_SITE_MOZILLA becomes
Frederick> unnecessary.

Well, I won't insist on my change if my question is solved.

--
SUNAGAWA Keiki <kei_sun@ba2.so-net.ne.jp>
http://www05.u-page.so-net.ne.jp/ba2/kei_sun/
http://frill.yi.org/~kei/