On Sat, Mar 08, 2003 at 10:27:25PM +1100, grant beattie wrote:
> On Sat, Mar 08, 2003 at 10:15:41AM +0100, Lubomir Sedlacik wrote:
>=20
> > > Modified Files:
> > > 	pkgsrc/mk: bsd.pkg.defaults.mk
> > >=20
> > > Log Message:
> > > provide CDRECORD_CONF.
> >=20
> > what's the point of having this variable?  isn't setting
> > PKG_SYSCONFDIR good enough?
>=20
> Yes, it uses PKG_SYSCONFDIR/cdrecord.conf, so setting that will also
> change the path.
>=20
> CDRECORD_CONF, on the other hand, allows users to set the full
> pathname, possibly to the previous (hardcoded) default
> `/etc/default/cdrecord', which is desirable considering the author's
> wishes.

i think we have PKG_SYSCONFDIR and converting all packages to this
framework for a reason and making such an unnecessary diversity is
harmful.  those who want cdrecord.conf in /etc/default/cdrecord can set
PKG_SYSCONFDIR.cdrecord to /etc/default/cdrecord in their /etc/mk.conf.

CDRECORD_CONF is superfluous, please back out this change and fix
cdrecord to directly use PKG_SYSCONFDIR.  thanks.


regards,

--=20
-- Lubomir Sedlacik <salo@Xtrmntr.org>                   --
--                  <salo@silcnet.org>                   --