On Sun, Jun 29, 2003 at 11:19:10AM +0000, Thomas Klausner wrote:
> 
> Module Name:	pkgsrc
> Committed By:	wiz
> Date:		Sun Jun 29 11:19:09 UTC 2003
> 
> Modified Files:
> 	pkgsrc/converters/libiconv: buildlink2.mk
> 
> Log Message:
> Check for existence of /usr/lib/libiconv.so too, not only for the header
> file. Needed for some broken (Linux) installs.
> >From Sebastian P. on tech-pkg.

This isn't right.  Checking for whether /usr/lib/libiconv.so exists
already happens in the _BLNK_LIBICONV_LIST manipulation, which sets
_BLNK_LIBICONV_FOUND to YES/NO dependeing on whether some sort of
libiconv.* library is found in /usr/lib.  Adding the explicit test for
/usr/lib/libiconv.so as your change does skips setting a lot of
necessary variables that later parts of the buildlink2.mk file rely on,
so if this change "works" on some Linux platform, then it's entirely by
accident.  I'd like for this change be backed out until we can determine
what's actually going wrong.

I wasn't able to follow the thread on tech-pkg because I didn't
understand what the actual bug report was, and the build log that was
originally posted didn't bear any relationship to the bug report.  I'd
rather that this bug be handled through the usual channels (via send-pr).

	Cheers,

	-- Johnny Lam <jlam@jgrind.org>