--NHfequSh1hmJPP0s
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

hi,

On Wed, Apr 14, 2004 at 04:59:38PM +0200, Julio M. Merino Vidal wrote:
> On Wed, 14 Apr 2004 15:14:20 +0200, Lubomir Sedlacik wrote:
> >
> > as stated in the PR:
> >=20
> >  "I've diffed bmp 0.9.6 and 0.9.6.1, the changes are very very
> >  minimal, they've just incorporated patch-af, so it's no longer used
> >  and thus removed by my patch"
>=20
> As I understood, it included patch-af *aside* other fixes; I didn't
> check the distfiles myself, but I checked the ChangeLog (which didn't
> make this better).

the "other" fixes are very simple oneliners related to the process of
creating a distribution file, pkgsrc (and end-user at all)-unrelated.
well, it's not a rocket science when even the submitter himself says
"they've just incorporated patch-af"..

> > now we have two identical packages with different version numbers,
> > confused people who upgrade for no reason, waster space on ftp,
> > unnecessary revisions in cvs, just for a sake of "blindly committing
> > a random from a PR".
            ^
        eww, patch

> I don't commit any patch from PRs without prior testing, so it's not
> "blindly".

by "blindly" i meant "without considering possible consequences" in this
case.

> > did you even bother to read the PR trail before committing?
>=20
> Of course.

i meant my reply in the Audit-Trail: section, which was there before
your actual commit, which asked the submitter about the point of the PR
at all.  i exchanged few mails with him in private (since he replied to
my mail that way) and agreed the PR could be closed without applying the
patch, only to come and see you committed in meanwhile..  i should have
set it to "feedback" state, perhaps, but i expected anyone looking at
the PR to actually read it..

> Thanks for those explanations.  I didn't think about them, ever (so
> yet one other thing to consider in the future).

you're welcome, i make mistakes too.  i think it's about the time to cut
this thread, i hope you don't take it as a personal offense ;).  (and
others at least got some more ideas what to think about before
committing changes).


regards,

--=20
-- Lubomir Sedlacik <salo@{NetBSD,Xtrmntr,silcnet}.org>   --

--NHfequSh1hmJPP0s
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (NetBSD)

iD8DBQFAfVbmiwjDDlS8cmMRAgNDAJ4vWdzpzzcLGlLBka7kwVnWT4d30QCbBW0F
ATkl48+U3BOdpCW9ui+4n9E=
=WGw0
-----END PGP SIGNATURE-----

--NHfequSh1hmJPP0s--