Subject: Re: CVS commit: pkgsrc/mk/install
To: Todd Vierling <tv@duh.org>
From: Johnny C. Lam <jlam@NetBSD.org>
List: pkgsrc-changes
Date: 02/14/2005 12:13:39
Todd Vierling wrote:
> On Mon, 14 Feb 2005, Johnny Lam wrote:
>
>
>>>(This test appears to work around a case where two files were exactly the
>>>same by inode, and have the script *not* delete the file in that case.
>>>I'm not exactly sure why that is desirable at all.)
>>
>>This is to catch errors in adding files from the PLIST to the list of files
>>managed by the +INSTALL/+DEINSTALL scripts.
>
>
> No, the code as written would have papered over such errors rather than
> properly causing error messages (by preventing +FILES from removing the
> file, and thus preventing the actually correct "maybe the packing list is
> correct?" error).
At the time bsd.pkg.install.mk was originally committed, we didn't have
a clear consensus on how to handle config files within pkgsrc. Many
packages were still installing example config files directly into
${LOCALBASE}/etc and listing the files into the PLIST. The currently
accepted way of doing it (installing the examples into
${LOCALBASE}/share/examples/${PKGBASE} and then adding CONF_FILES
definitions to the package Makefile) only came about after many packages
were converted, and people started to see how using bsd.pkg.install.mk
made config-file-handling much nicer. Due to the lack of a consensus at
the time, there are more safety checks in the +INSTALL/+DEINSTALL
scripts than are absolutely necessary.
Cheers,
-- Johnny Lam <jlam@NetBSD.org>