On 10/1/05, Steven M. Bellovin <smb@netbsd.org> wrote:
>
> Module Name:    pkgsrc
> Committed By:   smb
> Date:           Sat Oct  1 15:43:51 UTC 2005
>
> Modified Files:
>         pkgsrc/audio/gtkpod: Makefile distinfo
> Added Files:
>         pkgsrc/audio/gtkpod: MESSAGE.NetBSD
> Removed Files:
>         pkgsrc/audio/gtkpod: MESSAGE
>
> Log Message:
> Fix minor glitches in original commit: MESSAGE vs MESSAGE.NetBSD,
> missing getttext-lib/buildlink3.mk, lack of RMD160 checksum

Also, you could:
- Sort the inclusion of all buildlink3.mk files alphabetically (except for =
those
  in mk/, which should be kept at the bottom.
- Keep all the USE_* vars in the same block (you currently have two differe=
nt
  "paragraphs"), and sort them all alphabetically.
- Remove the BUILDLINK_DEPENDS line; gtk2 already pulls in 2.4.0 at a
  minimum.
- patch-ab assumes we are using statvfs, while that may be false in some
  platforms.  A check should be added to configure.in, using its results
  instead.

Cheers,

--
Julio M. Merino Vidal <jmmv84@gmail.com>
http://www.livejournal.com/users/jmmv/
The NetBSD Project - http://www.NetBSD.org/