In message <6b2d1e190510010849j211b9502m31a9b573a1730255@mail.gmail.com>, "Juli
o M. Merino Vidal" writes:

>
>Also, you could:
>- Sort the inclusion of all buildlink3.mk files alphabetically (except for tho
>se
>  in mk/, which should be kept at the bottom.

ok

>- Keep all the USE_* vars in the same block (you currently have two different
>  "paragraphs"), and sort them all alphabetically.

ok

>- Remove the BUILDLINK_DEPENDS line; gtk2 already pulls in 2.4.0 at a
>  minimum.

I thought about that one beforehand, but left it in deliberately, for 
two reasons: first, I didn't want to make any unnecessary assumptions 
about other packages; second, the configure script checks for that 
explicitly, and I wanted to make sure that any potential errors would 
be expressed in pkgsrc terms.

>- patch-ab assumes we are using statvfs, while that may be false in some
>  platforms.  A check should be added to configure.in, using its results
>  instead.

Hmm -- how do I do that?  I've never used autoconf, and the language in 
that file looks rather arcane.

		--Steven M. Bellovin, http://www.cs.columbia.edu/~smb