On 10/1/05, Steven M. Bellovin <smb@cs.columbia.edu> wrote:
> In message <6b2d1e190510010849j211b9502m31a9b573a1730255@mail.gmail.com>,=
 "Juli
> o M. Merino Vidal" writes:
> >- Remove the BUILDLINK_DEPENDS line; gtk2 already pulls in 2.4.0 at a
> >  minimum.
>
> I thought about that one beforehand, but left it in deliberately, for
> two reasons: first, I didn't want to make any unnecessary assumptions
> about other packages; second, the configure script checks for that
> explicitly, and I wanted to make sure that any potential errors would
> be expressed in pkgsrc terms.

We remove them even in these cases.  Versions in buildlink3.mk files never
go back, so when they are raised, pkgsrc is swept for greater lines overrid=
ing
the value in bl3.mk and are removed.

> >- patch-ab assumes we are using statvfs, while that may be false in some
> >  platforms.  A check should be added to configure.in, using its results
> >  instead.
>
> Hmm -- how do I do that?  I've never used autoconf, and the language in
> that file looks rather arcane.

It depends on the current contents of configure.in; sometimes it's trivial,
sometimes it's not.  There are plenty of examples in pkgsrc on how to do
that, but typically it means adding 'sys/statvfs.h' to an existing
AC_CHECK_HEADERS line, 'statvfs' to an existing AC_CHECK_FUNCS
line and using HAVE_SYS_STATVFS_H and HAVE_STATVFS later on.

Cheers,

--
Julio M. Merino Vidal <jmmv84@gmail.com>
http://www.livejournal.com/users/jmmv/
The NetBSD Project - http://www.NetBSD.org/