Subject: Re: CVS commit: pkgsrc/multimedia/libdvdcss
To: Jeremy C. Reed <reed@reedmedia.net>
From: Dieter Baron <dillo@danbala.tuwien.ac.at>
List: pkgsrc-changes
Date: 10/11/2005 19:01:05
hi,

> >Log Message:
> >Add a reminder not to add INTERACTIVE_STATE=fetch.  It has been
> >added and removed twice in the last two months.
> 
> The message added is not why it was removed. I made it work fine by 
> checking if that LIBDVDCSS_MASTER_SITES was defined. The whole routine was 
> removed because, I was told, due to "legal" wording.

  None the less, the setting INTERACTIVE_STATE=fetch has been added in
revision 1.7 by kirsterw on 2005/07/20 (okay, more than two months),
removed in reviwion 1.8 on 2005/07/21 (by kristerw after prompting by
me), readded yesterday in revision 1.10 by you, removed again
yesterday in revision 1.13 by agc.

  As I noted the first time around, fetch in libdvdcss is not
interactive, it just requires setting a variable in mk.conf (or
equivalent).  Thus, it should not be marked as such.

  In order to avoid yet another round of adding/removing this, I added
the reminder.

  The proper way to fix the problem these two attempts were trying to
solve is to make fetch fail in a clean way if LIBDVDCSS_MASTER_SITES
is not defined.

					yours,
					dillo