> Delivered-To: dauphin@enst.fr
> X-Original-To: pkgsrc-changes@NetBSD.org
> Delivered-To: pkgsrc-changes@NetBSD.org
> From: joerg@britannica.bec.de
> To: pkgsrc-changes@NetBSD.org
> Subject: Re: CVS commit: pkgsrc/multimedia/x264-devel
> Mail-Followup-To: pkgsrc-changes@NetBSD.org
> Content-Disposition: inline
> User-Agent: Mutt/1.5.11
> X-Virus-Scanned: amavisd-new at enst.fr
> 
> On Thu, Feb 23, 2006 at 12:09:45PM +0100, Gilles Dauphin wrote:
> > > Log Message:
> > > Add build time dependency on nasm / yasm for i386 and amd64.
> > 
> > I would like the following:
> 
> I strongly object that.
> 
> > because 'generic' solaris MACHINE_ARCH is i386 and don't take care of ABI.
> > Second, x86_64 Solaris MACHINE_ARCH does not exist in pkgsrc.
> > maybe it is also true for other system with bi-arch (32/64) ABI.
> 
> Solaris platform files should fix up the MACHINE_ARCH in that case.
> A lot of packages will be broken by this because everyone else does not
> use i386 for the 64bit ABI.

If it does not use i386 for 64 bit ABI, it fall into the elif part
and use the correct x86 assembler (yasm). Is it wrong? 
Gilles


.if ${MACHINE_ARCH} == "i386"
.  if ${ABI} != "64"
BUILD_DEPENDS+=       nasm>=0.98.34:../../devel/nasm
.  else
BUILD_DEPENDS+=       yasm>=0.4.0:../../devel/yasm
.  endif
.elif ${MACHINE_ARCH} == "x86_64"
BUILD_DEPENDS+=       yasm>=0.4.0:../../devel/yasm
.endif