Subject: Re: CVS commit: pkgsrc/audio/libtunepimp
To: Juan Romero Pardines <xtraeme@netbsd.org>
From: Thomas Klausner <wiz@NetBSD.org>
List: pkgsrc-changes
Date: 02/13/2007 22:09:47
Hi!

I assume you did the following change for kdemultimedia:

On Sat, Feb 10, 2007 at 07:44:11PM +0000, Juan Romero Pardines wrote:
> Modified Files:
> 	pkgsrc/audio/libtunepimp: buildlink3.mk
> 
> Log Message:
> Use BUILDLINK_FNAME_TRANSFORM and move the header files from
> ${PREFIX}/include/tunepimp-0.5 to ${PREFIX}/include/tunepimp.
> 
> We need the header files at this location for some packages
> (and avoid unnecessary patches) like kdemultimedia3.

I find it ironic that your next commit on the subject was:

On Sun, Feb 11, 2007 at 12:00:31PM +0000, Juan Romero Pardines wrote:
> 
> Module Name:	pkgsrc
> Committed By:	xtraeme
> Date:		Sun Feb 11 12:00:31 UTC 2007
> 
> Modified Files:
> 	pkgsrc/audio/amarok: distinfo
> Added Files:
> 	pkgsrc/audio/amarok/patches: patch-ac
> 
> Log Message:
> Add a patch to fix build with the newest tunepimp's buildlink3.mk file.

Also, if you look closely, kdemultimedia does not support tunepimp-0.5
at all, from its configure script:
echo "$as_me: WARNING: Tunepimp 0.5 detected - disabled." >&2;}

Please revert these two changes.

Thanks,
 Thomas