Subject: Re: CVS commit: pkgsrc/pkgtools/pbulk
To: None <pkgsrc-changes@NetBSD.org>
From: Joerg Sonnenberger <joerg@britannica.bec.de>
List: pkgsrc-changes
Date: 08/05/2007 15:37:45
On Sun, Aug 05, 2007 at 12:30:10PM +0000, Tobias Nygren wrote:
> Log Message:
> Do SUBST handling in post-patch instead of pre-configure. This makes
> substitution (and any substitution warnings) run before the build starts,
> rather than after building libnbcompat. The reason for this is that
> libnbcompat is _built_ in the pre-configure stage when in inplace mode.
It is also good practise to carefully consider what to do post-patch.
SUBSTing in that phase makes it a lot harder for many packages to create
proper patches... It doesn't really matter here, but for other packages
I would have asked to revert this.
Joerg