Subject: Re: CVS commit: pkgsrc/mk/check
To: None <pkgsrc-changes@NetBSD.org>
From: Johnny C. Lam <jlam@buildlink.org>
List: pkgsrc-changes
Date: 08/23/2007 09:25:58
Joerg Sonnenberger wrote:
> On Tue, Aug 21, 2007 at 09:44:23PM +0000, Johnny C. Lam wrote:
>> Log Message:
>> Allow the existence of symlinks that point nowhere.
>
> In general I think this is a bad idea. Too many packages over the time
> had broken links that pointed to bad installations.
That check is inappropriate for what check-files is supposed to do,
which is the verify that the installed files and symlinks match the
PLIST. It doesn't matter if the symlink points nowhere because the
symlink is still installed on the system and is in the PLIST. The
check-files target should care about the symlink, not what it's pointing to.
If you want to verify that all symlinks point to valid entries, you can
implement a different check target for that.
Cheers,
-- Johnny Lam <jlam@buildlink.org>