Subject: Re: CVS commit: pkgsrc
To: None <pkgsrc-changes@NetBSD.org>
From: Roland Illig <rillig@NetBSD.org>
List: pkgsrc-changes
Date: 09/08/2007 03:09:52
Joerg Sonnenberger wrote:
> On Fri, Sep 07, 2007 at 03:45:15PM +0000, Roland Illig wrote:
>
>>Module Name: pkgsrc
>>Committed By: rillig
>>Date: Fri Sep 7 15:45:15 UTC 2007
>>
>>Modified Files:
>> pkgsrc/bootstrap: bootstrap
>> pkgsrc/pkgtools/pkg_install/files/add: perform.c
>> pkgsrc/pkgtools/pkg_install/files/delete: main.c
>>
>>Log Message:
>>In unprivileged builds, the user running pkg_add and pkg_delete is
>>almost always an unprivileged user. So there's no point in printing a
>>warning in that case.
>
>
> I disagree with this change
Why?
Is there a case where printing the warning is actually useful? Normal
users shouldn't run pkg_add or pkg_delete anyway.
> and I disagree with creating different
> packages for bootstrap and direct installation.
That's a valid complaint. Having the following lines in
pkgtools/pkg_install/Makefile should be a better solution:
.if ${UNPRIVILEGED:M[Yy][Ee][Ss]} != ""
CPPFLAGS+= -DUNPRIVILEGED
.endif
Roland