Re: CVS commit: pkgsrc/cross/mingw-binutils

[Aleksej Saushev <asau%inbox.ru@localhost>]

John Marino <netbsd%marino.st@localhost> writes:

> On 10/9/2012 16:29, Aleksej Saushev wrote:
>> "John Marino"<marino%netbsd.org@localhost>  writes:
>>
>>> Module Name:        pkgsrc
>>> Committed By:       marino
>>> Date:               Tue Oct  9 07:48:21 UTC 2012
>>>
>>> Modified Files:
>>>     pkgsrc/cross/mingw-binutils: Makefile
>>>
>>> Log Message:
>>> cross/mingw-binutils: Fix build on gcc4.7
>>>
>>> mingw-binutils is built with -Werror which fails on the gcc4.6+ warning
>>> "unused but set variable".  Disable that warning to fix gcc4.7 build.
>>
>> I suggest that you stop suppressing warnings just to make it build with
>> your compiler. If you know what the problem is, fix the problem.
>
> It's not "my" compiler, it's gcc 4.6+ (see
> http://gcc.gnu.org/gcc-4.6/changes.html  caveats, bullet 6)
>
> 1) It's not a problem.
> 2) I'm not going to add countless patches to source inside
> tarball for something that the compiler will optimize out
> anyway.  That would cause a real headache for the next guy.
> 3) It didn't cause any problems undetected
> 4) It's the package's fault for compiling with -Werror
>
> So I'm going to ignore that suggestion.  It's a bad one.

If it is not a problem, then you shouldn't have introduced the change.

Currently you have left package in a broken state since you use flag
that isn't supported across GCC versions in current use.

Please, revert.


-- 
HE CE3OH...