Re: CVS commit: pkgsrc/devel/glib2

[Patrick Welche <prlw1%cam.ac.uk@localhost>]

On Tue, Oct 08, 2019 at 09:58:40AM +0100, Jonathan Perkin wrote:
> * On 2019-10-08 at 09:48 BST, Patrick Welche wrote:
> 
> > +CPPFLAGS.SunOS+=   -D_XOPEN_SOURCE=1 -D_XOPEN_SOURCE_EXTENDED=1
> 
> This is wrong, you can't hardcode _XOPEN_SOURCE.  glib2 will now be
> broken on any system using GCC 5 or newer.
> 
> USE_LANGUAGES is already set to C99 so it's highly unlikely glib2 is
> actually requiring XPG4v2 specifically here, but does mean that it is
> at least safe to use 600 or higher.

I thought it was safe having seen a similar change to PHP a while ago -
it had unintended consequences for "uint", "uchar", but they only
appear in glib2's windows code.

I'll leave it to you to do the right thing (cus.cam.ac.uk no longer exists)

Cheers,

Patrick