Hi,
SUBST_NOOP_OK is good feature for me.
However it breaks pkgtools/pkg_chk tool.
Could you take a look at my problem?
A error message is as follows:
$ pkg_chk -un
cd: can't cd to /usr/tmp/pkgsrc/archivers/gtar-base/work/tar-1.32
make: "cd /usr/tmp/pkgsrc/archivers/gtar-base/work/tar-1.32 &&
echo "__dummy-entry__" && /usr/bin/find .
\( -name "[Mm]akefile.in*" \) -print | /usr/bin/sed -e 's|^\./||' |
/usr/bin/sort -u" returned non-zero status
cd: can't cd to /usr/tmp/pkgsrc/x11/gtk2/work/gtk+-2.24.32
make[1]: "cd /usr/tmp/pkgsrc/x11/gtk2/work/gtk+-2.24.32 &&
echo "__dummy-entry__" && /usr/bin/find .
\( -name "[Mm]akefile.in*" \) -print | /usr/bin/sed -e 's|^\./||' |
/usr/bin/sort -u" returned non-zero status
cd: can't cd to /usr/tmp/pkgsrc/audio/pulseaudio/work/pulseaudio-13.0
make: "cd /usr/tmp/pkgsrc/audio/pulseaudio/work/pulseaudio-13.0 &&
echo "__dummy-entry__" && /usr/bin/find .
\( -name "[Mm]akefile.in*" \) -print | /usr/bin/sed -e 's|^\./||' |
/usr/bin/sort -u" returned non-zero status
cd: can't cd to /usr/tmp/pkgsrc/x11/gtk3/work/gtk+-3.24.14
make[1]: "cd /usr/tmp/pkgsrc/x11/gtk3/work/gtk+-3.24.14 &&
(snip)
Thank you.
"Roland Illig" <rillig%netbsd.org@localhost> writes:
Module Name: pkgsrc
Committed By: rillig
Date: Thu Mar 19 16:57:35 UTC 2020
Modified Files:
pkgsrc/mk: subst.mk
Log Message:
mk/subst.mk: add SUBST_NOOP_OK to catch typos and outdated definitions
In a bulk build with very strict settings (WARNING_MSG fails, as well as
no-op substitutions), it became clear that nearly all of the cases where
SUBST didn't replace anything were bugs in the package definition.
Most of them were just outdated, which is no surprise given that some
packages are already over 20 years old.
For backwards compatibility, SUBST_NOOP_OK defaults to "yes" right now.
After correcting the affected packages, the default will change to "no".
To generate a diff of this commit:
cvs rdiff -u -r1.62 -r1.63 pkgsrc/mk/subst.mk
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.