CVS commit: pkgsrc/pkgtools/check-portability/files

["Roland Illig" <rillig%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   rillig
Date:           Sun Apr 19 12:47:27 UTC 2020

Modified Files:
        pkgsrc/pkgtools/check-portability/files: check-portability.c

Log Message:
pkgtools/check-portability: make test == an error

It had only been a warning before, due to a forgotten nerrors++. The
check in mk/check/check-portability.awk already treats this case as an
error.


To generate a diff of this commit:
cvs rdiff -u -r1.13 -r1.14 \
    pkgsrc/pkgtools/check-portability/files/check-portability.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/pkgtools/check-portability/files/check-portability.c
diff -u pkgsrc/pkgtools/check-portability/files/check-portability.c:1.13 pkgsrc/pkgtools/check-portability/files/check-portability.c:1.14
--- pkgsrc/pkgtools/check-portability/files/check-portability.c:1.13    Sun Apr 19 12:05:14 2020
+++ pkgsrc/pkgtools/check-portability/files/check-portability.c Sun Apr 19 12:47:27 2020
@@ -1,4 +1,4 @@
-/* $NetBSD: check-portability.c,v 1.13 2020/04/19 12:05:14 rillig Exp $ */
+/* $NetBSD: check-portability.c,v 1.14 2020/04/19 12:47:27 rillig Exp $ */
 
 /*
  Copyright (c) 2020 Roland Illig
@@ -389,6 +389,7 @@ checkline_sh_dollar_random(cstr filename
        printf("%s:%zu:%zu: $RANDOM: %s\n",
            cstr_charptr(filename), lineno, idx + 1,
            cstr_charptr(line));
+       // No nerrors++ since this is not critical.
        explain(
            W_dollar_random,
            "The variable $RANDOM is not required for a POSIX-conforming shell, and",
@@ -437,6 +438,7 @@ checkline_sh_test_eqeq_action(cstr f1, c
            cstr_charptr(ad->filename), ad->lineno,
            (size_t) (f3.data - ad->line.data),
            cstr_charptr(ad->line));
+       nerrors++;
        explain(
            W_test_eqeq,
            "The \"test\" command, as well as the \"[\" command, are not required to know",