Re: CVS commit: pkgsrc

[Roland Illig <roland.illig%gmx.de@localhost>]

On 01.05.2020 16:57, Joerg Sonnenberger wrote:
> On Fri, May 01, 2020 at 06:42:32AM +0000, Roland Illig wrote:
> > Module Name:    pkgsrc
> > Committed By:   rillig
> > Date:           Fri May  1 06:42:32 UTC 2020
> >
> > Modified Files:
> >         pkgsrc/mk: subst.mk
> >         pkgsrc/regress/infra-unittests: subst.sh
> >
> > Log Message:
> > mk/subst.mk: switch command substitution back to backticks
> >
> > To work properly, the $(...) should have been $$(...).
> >
> > In pkgsrc the command substitution is usually done via `backticks`, for
> > compatibility with /bin/sh from Solaris.  To fix the shell parse errors,
> > the special characters are properly escaped inside the command
> > substitution.
>
> You know, I even gave you a test case for where the original code fails.
> Why don't you try fixing that instead of blindly reverting other
> people's changes?

I didn't revert your changes blindly. Exactly the opposite, I carefully
inspected it, noticed that you had introduced a syntax error and
therefore reverted that part.

After your change, the code may have seemed to work in your case, but it
also made the tests in regress/infra-unittests fail.

Therefore, I also added a unit test to ensure that the code now works
for the test case you gave. Thanks for that, I had totally missed that
combination.