Re: CVS commit: pkgsrc/games/eureka

[Jonathan Perkin <jperkin%joyent.com@localhost>]

* On 2020-05-15 at 15:59 BST, Michael Baeuerle wrote:

> +# Error on SmartOS 20200130T160054Z/x86_64:
> +# [...]
> +# src/e_basis.cc:1200:57: error: expected ',' or '...' before numeric constant
> +#  1200 | static void ChecksumSector(crc32_c& crc, const Sector * SEC)
> +#       |                                                         ^~~
> +# src/e_basis.cc: In function 'void ChecksumSector(crc32_c&, const Sector*)':
> +# src/e_basis.cc:1202:12: error: base operand of '->' is not a pointer
> +#  1202 |  crc += SEC->floorh;
> +#       |            ^~
> +BROKEN_ON_PLATFORM=  SunOS-*-*

Please don't do this, there is absolutely no benefit in adding BROKEN
for things that can easily be fixed, and makes it much harder to
investigate.

There is no harm in having packages show up in bulk build reports,
after all that's the entire point of publishing them!  Users can then,
if they notice a package is unavailable, go and find out what the
cause is.  Packages that are marked as BROKEN just show up as
unavailable with no useful details at all.

I've gone ahead and fixed the package, as well as removing this.

Thanks,

-- 
Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com