Re: CVS commit: pkgsrc/devel/ninja-build

[Leonardo Taccari <leot%NetBSD.org@localhost>]

Hello Adam,

Adam Ciarcinski writes:
> [...]
> Log Message:
> ninja-build: updated to 1.10.1
>
> v1.10.1
> See https://groups.google.com/g/ninja-build/c/QQM54eAhrjU/m/q5zn_zTlAQAJ for the v1.10.1 release notes.
> [...]

Please avoid using URLs that needs that are under *wall (it seems that
only people with a Google account can read it) and directly include them
inline in the commit message.  In that case the corresponding email doesn't
seem to be particularly long too.

Quoting relevant part of the email here:

 | 1.10.0 introduced the restat tool, which CMake 3.17 uses to update the
 | timestamps in .ninja_log to avoid having to run some rules twice after
 | regenerating. This didn't work on Windows though, as you can't write to
 | a file which is opened for writing by another process there. To clarify
 | what I mean imagine you have the following hierarchy:
 | 
 | a.) ninja
 | b.) -> regenerate by calling CMake
 | c.) -> -> CMake calls ninja -t restat
 | d.) ninja continues the build and rereads the build manifest
 | 
 | Between a.) and d.) the outer ninja process would (unnecessarily) open
 | .ninja_log, but not write anything to it yet. c.) would then fail on
 | Windows.
 | 
 | After https://github.com/ninja-build/ninja/pull/1780 ninja will now
 | open .ninja_log on the first write - so during d.) - or if it has
 | finished. In the future we could even avoid creating .ninja_log if it
 | would be empty, but I didn't want to change too much of the behavior in
 | a minor release (it would also require touching some unit tests).
 | 
 | The other change is that the automatic build on GitHub Actions now
 | builds binaries compatible with macOS 10.12 (previously they required
 | 10.14 IIRC).
 | 
 | For a complete list of changes see:
 | https://github.com/ninja-build/ninja/compare/v1.10.0...00968321d6ace10b6798855cab7620dc6a5620fd


Thanks!