Re: CVS commit: pkgsrc/lang/nodejs

[Jonathan Perkin <jperkin%pkgsrc.org@localhost>]

* On 2020-12-16 at 07:43 GMT, Adam Ciarcinski wrote:

> Module Name:  pkgsrc
> Committed By: adam
> Date:         Wed Dec 16 07:43:13 UTC 2020
> 
> Modified Files:
>       pkgsrc/lang/nodejs: Makefile.common
> 
> Log Message:
> PYTHON_VERSIONS_ACCEPTED is not common anymore

Adam,

I honestly do not know at this point whether you deliberately break things
for fun, knowing the frustration it causes me when I have to go around
fixing your mistakes, or whether you are just completely ignorant.

Sometimes I can understand it.  The constant python bulk build breakages
are I guess sometimes understandable.  I mean, sure, running a couple of
greps can be really hard.  I get it.  It's easier to just commit and let
others fix things for you when you have no pride in your work.

But this.  I don't understand it.  You keep breaking the same thing over
and over again, and I keep having to fix it.  The last time I had to clear
up your mess, I added what I thought was a very very clear comment:

> -#
> -# Do not remove this unless you are absolutely certain that every python script
> -# in every nodejs that we support is python3 ready.
> -#
> -#PYTHON_VERSIONS_ACCEPTED=   27

Is this just a language thing, perhaps the English words I'm using are not
familiar to you?  I'm happy to re-word it if you think it will help.

It's pretty simple.  The node build is _not_ compatible with python3.  It
never is.  It always breaks.  It came as absolutely no surprise to me when
I tested your update and of course it failed yet again, as it always does:

  Traceback (most recent call last):
  File "tools/genv8constants.py", line 97, in <module>
    match = pattern.match(line)
  TypeError: cannot use a string pattern on a bytes-like object
  gmake[1]: *** [node_dtrace_ustack.target.mk:13: /home/pbulk/build/lang/nodejs/work/node-v14.15.2/out/Release/obj/gen/v8constants.h] Error 1
  gmake[1]: *** Waiting for unfinished jobs....
  rm 797ec3203d1bdb3e6d735ab31776d87103c63c83.intermediate 9bd0091cd0a0ab8d7af56e374b5e50ba13125e00.intermediate ef52ae0d6675f332617b08865aeb3d0611683f50.intermediate
  gmake: *** [Makefile:104: node] Error 2
  *** Error code 2

  Stop.
  bmake[1]: stopped in /data/pkgsrc/pkgsrc-upstream-trunk/lang/nodejs

I don't even know what you're trying to accomplish with this constant
desire to break the node build.  It's not as if you are saving people from
having to install python2, as we set PYTHON_FOR_BUILD_ONLY=yes.  There is
no tangible benefit to your change, even if it did work.

Whatever it is, please, please, please stop.  If you aren't sure, just
ask.  A comment like that should make you stop and think that perhaps
whatever build you are performing isn't affected in the same way that
others are.  That's why I wrote "every python script" in my comment, not
just the ones that happen to be used in your builds.

And maybe, just maybe, have some empathy for other developers and users of
pkgsrc.  I'd appreciate it if you could revert this yourself rather than
forcing me to.

-- 
Jonathan Perkin       www.perkin.org.uk
github.com/jperkin  twitter.com/jperkin