CVS commit: pkgsrc/graphics/papirus-icon-theme

["Jonathan Perkin" <jperkin%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   jperkin
Date:           Wed Jan 13 18:26:24 UTC 2021

Modified Files:
        pkgsrc/graphics/papirus-icon-theme: Makefile
Removed Files:
        pkgsrc/graphics/papirus-icon-theme: PLIST

Log Message:
papirus-icon-theme: Switch to dynamic PLIST.

The static PLIST was incorrect, listing a number of directories instead of the
files contained within them.  For some reason the check-files infrastructure
does not complain about this on NetBSD, and was only noticed on SunOS.

Fixing the PLIST to correctly register the 750,000+ files that this package
installs would bloat it to 44MB and be painful to maintain, so while dynamic
PLISTs are generally to be avoided, in this situation it's the least worst.

Ok nia.


To generate a diff of this commit:
cvs rdiff -u -r1.9 -r1.10 pkgsrc/graphics/papirus-icon-theme/Makefile
cvs rdiff -u -r1.9 -r0 pkgsrc/graphics/papirus-icon-theme/PLIST

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/graphics/papirus-icon-theme/Makefile
diff -u pkgsrc/graphics/papirus-icon-theme/Makefile:1.9 pkgsrc/graphics/papirus-icon-theme/Makefile:1.10
--- pkgsrc/graphics/papirus-icon-theme/Makefile:1.9     Sun Mar 22 11:39:52 2020
+++ pkgsrc/graphics/papirus-icon-theme/Makefile Wed Jan 13 18:26:23 2021
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.9 2020/03/22 11:39:52 nia Exp $
+# $NetBSD: Makefile,v 1.10 2021/01/13 18:26:23 jperkin Exp $
 
 DISTNAME=      papirus-icon-theme-20200301
 CATEGORIES=    graphics
@@ -15,9 +15,23 @@ EXTRACT_USING=       bsdtar
 USE_TOOLS+=    gmake
 ICON_THEMES=   yes
 
+#
+# This package installs over 750,000 files.  While dynamic PLISTs are to be
+# avoided where possible, trying to maintain a static PLIST for this many
+# files is impractical and would bloat the repository considerably.
+#
+# The install script is literally just "cp -R <list of dirs>", so there is
+# hopefully little to go wrong and result in a broken package.
+#
+CHECK_FILES=           no
+GENERATE_PLIST=                cd ${DESTDIR}${PREFIX};
+GENERATE_PLIST+=       ${FIND} share \( -type f -o -type l \) | ${SORT};
+
 # Save some time...
-CHECK_WRKREF_SKIP+=            share/icons/*/*/*/*.svg
 CHECK_INTERPRETER_SKIP+=       share/icons/*/*/*/*.svg
+CHECK_SHLIBS_SUPPORTED=                no
+CHECK_SSP_SUPPORTED=           no
+CHECK_WRKREF_SKIP+=            share/icons/*/*/*/*.svg
 
 .include "../../graphics/gnome-icon-theme/buildlink3.mk"
 .include "../../graphics/hicolor-icon-theme/buildlink3.mk"