CVS commit: pkgsrc/geography/qgis

["Greg Troxel" <gdt%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   gdt
Date:           Wed Nov 30 21:12:28 UTC 2022

Modified Files:
        pkgsrc/geography/qgis: Makefile

Log Message:
geography/qgis: Require C++17 and re-do gmake explanation

C++17 is clearly required, from reading qgis's cmake files.

Upstream qestioned that gmake is required, so document the failures
with BSD make.


To generate a diff of this commit:
cvs rdiff -u -r1.159 -r1.160 pkgsrc/geography/qgis/Makefile

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/geography/qgis/Makefile
diff -u pkgsrc/geography/qgis/Makefile:1.159 pkgsrc/geography/qgis/Makefile:1.160
--- pkgsrc/geography/qgis/Makefile:1.159        Mon Nov 28 14:25:31 2022
+++ pkgsrc/geography/qgis/Makefile      Wed Nov 30 21:12:28 2022
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.159 2022/11/28 14:25:31 gdt Exp $
+# $NetBSD: Makefile,v 1.160 2022/11/30 21:12:28 gdt Exp $
 
 # This is intentionally 3.28 Long Term Release.  Please do not update
 # to later branches, and instead discuss whether/how we want multiple
@@ -16,16 +16,15 @@ COMMENT=    Geographic Information System (
 LICENSE=       gnu-gpl-v2
 
 USE_CMAKE=             yes
-USE_LANGUAGES=         c c++11 fortran77
+USE_LANGUAGES=         c c++17 fortran77
 USE_LIBTOOL=           yes
 USE_PKGLOCALEDIR=      yes
 USE_TOOLS+=            cmake bison flex perl pkg-config
-# Due to gmake spaces in filenames, we must use gmake.  An example is
-# "resources/function_help/json/Date and Time".
-# Further, gmake expects files that contain a $ such as "$area" to
-# appear, unsurprisingly, as "$$area" on the RHS of dependency rules.
-# NetBSD make, expects "$$$$area".  While cmake 3.17 produced
-# "$$area", cmake 3.18 produces "$$$$area", perhaps only on NetBSD.
+# Building 3.28.1 fails with BSD make.  One issue seem to be a
+# difference of opinion about quoting of $, with gmake wanting
+# "$$area" vs bmake perhaps wanting "$$$$area".  Another is filenames
+# with spaces, which are \-quoted in Makefiles, but bmake sees them as
+# separate files.
 USE_TOOLS+=            gmake
 
 PLIST_SRC=             PLIST