pkgsrc-Changes archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
CVS commit: pkgsrc/sysutils/bup
Module Name: pkgsrc
Committed By: gdt
Date: Wed Dec 11 01:19:15 UTC 2024
Modified Files:
pkgsrc/sysutils/bup: Makefile PLIST distinfo
Log Message:
sysutils/bup: Update to 0.33.5
This is a micro but it fixes serious bugs so if you use get/gc you
really need to update!
Summary of upstream NEWS:
Notable changes in 0.33.5 since 0.33.4 (incomplete)
===================================================
May require attention
---------------------
* Problems have been discovered that could have allowed the creation
of incomplete trees or commits, for example `bup save` or `bup get`
could have created saves with missing data. This should no longer
be possible, but any existing incomplete trees might also be re-used
by `bup get` (for example), and so represent a continuing hazard.
Note that if you've never used `bup gc` or `bup get`, then we don't
currently believe your repositories could have been affected.
You can detect whether you've been affected by running
`bup-validate-object-links(1)`. If it doesn't report any broken
links (as `no HASH for PARENT_HASH`), then you can stop here, the
repository should be fine. You can also run `bup midx -af` first,
which may speed up the validation.
If it does report broken links, then you should run `bup gc --ignore
missing` to completion before making any further additions to the
repository. But first, if you have other repositories that might
still contain the missing objects, then you may want to try to
retrieve them. See "repopulate missing objects" below for details.
`bup gc --ignore-missing` will eliminate some of the hazards and
report at least one of the paths to each missing object.
If `gc` doesn't report any broken paths (missing objects), then you
can stop here, the repository should be fine.
If `gc` does report broken paths, then you should clear the related
indexes, e.g. `bup index --clear` or `bup on HOST index --clear`,
etc.
If you don't rely on `bup get` (e.g. if you only `save`) then
clearing the index(es) should ensure that new saves will be complete
(though existing broken saves will remain structurally broken for
now).
If you do rely on `bup get`, and if `gc` reports broken paths, then
there's not yet an easy way to ensure `get` won't continue to re-use
incomplete trees when building new saves. For now, you could start
a new repository (and save the old one for future repairs).
You can try to repopulate missing objects from the source (or some
other) repository. To do so, you can collect a list of missing
objects via `bup validate-object-links`:
bup validate-object-links | tee validate-out
grep -E '^no ' validate-out | cut -d' ' -f 2 | sort -u > missing-objects
sed -e 's/^/--unnamed git:/' missing-objects > unnamed-objects
and then try to retrieve the missing objects from another repository
via `bup get`. For example, perhaps:
xargs bup get --source repo --unnamed --ignore-missing < unnamed-objects
or
xargs bup on HOST get --unnamed --ignore-missing < unnamed-objects
After that, you can run `bup validate-object-links` to see whether
you were able to fix all of the broken references (i.e. whether it
still reports missing objects).
If you have enough missing objects, it's possible xargs might split
the argument list between `--unnamed` and its argument, causing
`get` to fail. If so, you can just specify an even numbered value
for `xargs -n`, for example `xargs -n 64 bup get ...`.
On most systems, you can choose a much larger `n`.
If you would just like to validate some saves, you can now run `bup
validate-ref-links SAVE...` which should be much more efficient than
attempting a restore or joining the saves to /dev/null.
We're also working on a command that will repair the structure of
any existing broken trees so that commands like restore will still
be able to work with them.
See issue/missing-objects.md for a detailed explanation of the
problem. If you have pandoc and graphviz dot installed, this will
be rendered to issue/missing-objects.html which you can open in a
browser, or you can find it
[here](https://bup.github.io/issue/missing-objects.html).
General
-------
* `bup validate-object-links` has been added. This command scans the
objects in the repository and reports any "broken links" it finds,
i.e. any links from a tree or commit in the repository to an object
that doesn't exist.
* `bup validate-ref-links` has been added. This command traverses
repository references (e.g. saves) and logs paths to missing
objects, i.e. references from a tree or commit to an object that
doesn't exist in the repository. At the moment, it will report at
least one path to each missing object; it does not attempt to find
all of the paths.
* `bup gc` now provides `--ignore-missing` which allows a `gc`
operation to continue after encountering objects that are missing
from the repository.
* `bup join` now reports the path to any missing object it encounters.
Bugs
----
* `bup gc` should no longer risk leaving the repository with
incomplete tree or commit objects -- trees or commits with
references to objects that are no longer in the repository.
Previously this could happen because the collection was
probabilistic with respect to all object types, and so it could
leave (completely orphaned) vestigial commits or trees that referred
to objects that had been removed. It could also do this if the
`--threshold` caused it to keep a parent in one "live enough" pack,
while discarding a descendant in a pack that doesn't cross the
threshold.
These objects can cause serious trouble because they can be re-used
as-is (without noticing that they are incomplete) by other commands
like `bup get`.
* `bup get` should no longer be able to leave the repository with
incomplete trees or commits if it's interrupted at the wrong time.
Previously it fetched objects "top down", and so if it was
interrupted after the parent tree/commit was written to the
repository, but before all the children were written, then the
repository would be left with an incomplete tree.
* `bup` should always ignore midx files that refer to missing indexes.
Previously it might not notice when objects had disappeared (via
`gc`) which could, in particular, cause remote/client operations
like a remote save to decide that the repository already contained
data that it did not.
* `bup midx` `--auto` and `--force` now delete midx files that refer
to missing indexes.
* `bup gc` should no longer throw bloom close-related exceptions when
interrupted.
Build system
------------
* [Graphviz](https://graphviz.org) `dot` is optional, but must be
available in order to render the figures referred to by
issue/missing-objects.md.
Thanks to (at least)
====================
Greg Troxel, Johannes Berg, and Rob Browning
To generate a diff of this commit:
cvs rdiff -u -r1.66 -r1.67 pkgsrc/sysutils/bup/Makefile
cvs rdiff -u -r1.12 -r1.13 pkgsrc/sysutils/bup/PLIST
cvs rdiff -u -r1.26 -r1.27 pkgsrc/sysutils/bup/distinfo
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: pkgsrc/sysutils/bup/Makefile
diff -u pkgsrc/sysutils/bup/Makefile:1.66 pkgsrc/sysutils/bup/Makefile:1.67
--- pkgsrc/sysutils/bup/Makefile:1.66 Mon Aug 26 13:57:02 2024
+++ pkgsrc/sysutils/bup/Makefile Wed Dec 11 01:19:15 2024
@@ -1,6 +1,6 @@
-# $NetBSD: Makefile,v 1.66 2024/08/26 13:57:02 gdt Exp $
+# $NetBSD: Makefile,v 1.67 2024/12/11 01:19:15 gdt Exp $
-DISTNAME= bup-0.33.4
+DISTNAME= bup-0.33.5
CATEGORIES= sysutils
MASTER_SITES= ${MASTER_SITE_GITHUB:=bup/}
# bup has two problems that make packaging difficult. One is that
Index: pkgsrc/sysutils/bup/PLIST
diff -u pkgsrc/sysutils/bup/PLIST:1.12 pkgsrc/sysutils/bup/PLIST:1.13
--- pkgsrc/sysutils/bup/PLIST:1.12 Sat Dec 9 01:46:30 2023
+++ pkgsrc/sysutils/bup/PLIST Wed Dec 11 01:19:15 2024
@@ -1,4 +1,4 @@
-@comment $NetBSD: PLIST,v 1.12 2023/12/09 01:46:30 gdt Exp $
+@comment $NetBSD: PLIST,v 1.13 2024/12/11 01:19:15 gdt Exp $
bin/bup
lib/bup/bup/__init__.py
lib/bup/bup/_helpers.so
@@ -39,6 +39,8 @@ lib/bup/bup/cmd/server.py
lib/bup/bup/cmd/split.py
lib/bup/bup/cmd/tag.py
lib/bup/bup/cmd/tick.py
+lib/bup/bup/cmd/validate_object_links.py
+lib/bup/bup/cmd/validate_ref_links.py
lib/bup/bup/cmd/version.py
lib/bup/bup/cmd/web.py
lib/bup/bup/cmd/xstat.py
Index: pkgsrc/sysutils/bup/distinfo
diff -u pkgsrc/sysutils/bup/distinfo:1.26 pkgsrc/sysutils/bup/distinfo:1.27
--- pkgsrc/sysutils/bup/distinfo:1.26 Mon Aug 26 13:57:02 2024
+++ pkgsrc/sysutils/bup/distinfo Wed Dec 11 01:19:15 2024
@@ -1,8 +1,8 @@
-$NetBSD: distinfo,v 1.26 2024/08/26 13:57:02 gdt Exp $
+$NetBSD: distinfo,v 1.27 2024/12/11 01:19:15 gdt Exp $
-BLAKE2s (bup-0.33.4.tar.gz) = 3713e1537fb1eaf15a84ee6260a8e3c27a39557537ac2c1009f89e69f22226ec
-SHA512 (bup-0.33.4.tar.gz) = d416f5e35fa3faa2281fc2382e03d357d4f4166cffe116aa3fb37b43e92d328e8dff4668e75c1e057feb4925c776ca35dfb4c64cb480ae574c3258071f5ff341
-Size (bup-0.33.4.tar.gz) = 478449 bytes
+BLAKE2s (bup-0.33.5.tar.gz) = 49513183517f9afb78cf427fae48472668f29464f7eb594713fb8da06444f4a9
+SHA512 (bup-0.33.5.tar.gz) = 00147f64ce6c56bf2197ba29f418784bcbee565dbfdf318d5ad1c4ba26d94b736855b901e359b37f60cbc28b5f24873b6c64906ba4da9c9ac7aab1c5eb519350
+Size (bup-0.33.5.tar.gz) = 497017 bytes
BLAKE2s (bup-man-fca676714d8fc3c4c76add0a5d30b4bd951e1c2f.tar.gz) = ff01865573777b7c1d408877009a15d6c572c5c0fbb75221d26d6d7aefc093c4
SHA512 (bup-man-fca676714d8fc3c4c76add0a5d30b4bd951e1c2f.tar.gz) = eb769b860fa3d5444f9b16830e4a125ecd3c5615f682c5199a97ab755500e0217998b8459fd577c85ff95a9a680a7ffe1795ad3cbbc50e4f01af0326eb043a51
Size (bup-man-fca676714d8fc3c4c76add0a5d30b4bd951e1c2f.tar.gz) = 33213 bytes
Home |
Main Index |
Thread Index |
Old Index