CVS commit: pkgsrc/math/suitesparse

["Jason Bacon" <bacon%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   bacon
Date:           Thu Dec 19 12:10:36 UTC 2024

Modified Files:
        pkgsrc/math/suitesparse: distinfo
Added Files:
        pkgsrc/math/suitesparse/patches:
            patch-ParU_Source_paru__init__rowFronts.cpp

Log Message:
math/suitesparse: Unbreak build on Alma 8

Some versions of GCC error out with omp default(none) shared(X)
when X is defined as const, stating that shared is predetermined.
Since const is only a compile-time check, and the code is
already build-tested with const, we can remove it without
altering runtime behavior.


To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5 pkgsrc/math/suitesparse/distinfo
cvs rdiff -u -r0 -r1.1 \
    pkgsrc/math/suitesparse/patches/patch-ParU_Source_paru__init__rowFronts.cpp

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/math/suitesparse/distinfo
diff -u pkgsrc/math/suitesparse/distinfo:1.4 pkgsrc/math/suitesparse/distinfo:1.5
--- pkgsrc/math/suitesparse/distinfo:1.4        Tue Aug 27 17:24:54 2024
+++ pkgsrc/math/suitesparse/distinfo    Thu Dec 19 12:10:35 2024
@@ -1,7 +1,8 @@
-$NetBSD: distinfo,v 1.4 2024/08/27 17:24:54 ktnb Exp $
+$NetBSD: distinfo,v 1.5 2024/12/19 12:10:35 bacon Exp $
 
 BLAKE2s (SuiteSparse-7.8.2.tar.gz) = 098fcd79dfe355e65b366e112745fa77dab1889cc48ae44bbb0158dc2bbd3100
 SHA512 (SuiteSparse-7.8.2.tar.gz) = beb9ea85b47e46785a91913d0b52ef86a59f797f3a3a6df4fced31c4f990277ef627b6baae52256dea10e60e4eff5e82e8b5a3d6e20a63de47953674cf34f921
 Size (SuiteSparse-7.8.2.tar.gz) = 87337633 bytes
 SHA1 (patch-GraphBLAS_CMakeLists.txt) = 2f32b3534f08bcfd7fa5fc53dccbc6fd283a9976
+SHA1 (patch-ParU_Source_paru__init__rowFronts.cpp) = 52fdeca699c598f745ce35210242f1480ab24426
 SHA1 (patch-SPQR_Source_spqr__factorize.cpp) = f8ad367e749435058f8df7c3961af8cf8b7dfb95

Added files:

Index: pkgsrc/math/suitesparse/patches/patch-ParU_Source_paru__init__rowFronts.cpp
diff -u /dev/null pkgsrc/math/suitesparse/patches/patch-ParU_Source_paru__init__rowFronts.cpp:1.1
--- /dev/null   Thu Dec 19 12:10:36 2024
+++ pkgsrc/math/suitesparse/patches/patch-ParU_Source_paru__init__rowFronts.cpp Thu Dec 19 12:10:36 2024
@@ -0,0 +1,25 @@
+$NetBSD: patch-ParU_Source_paru__init__rowFronts.cpp,v 1.1 2024/12/19 12:10:36 bacon Exp $
+
+# Fix build on Alma (RHEL) 8
+
+--- ParU/Source/paru_init_rowFronts.cpp.orig   2024-08-24 17:13:32.000000000 +0000
++++ ParU/Source/paru_init_rowFronts.cpp
+@@ -34,7 +34,17 @@ ParU_Info paru_init_rowFronts
+     ParU_Numeric *Num_handle,
+     // inputs, not modified:
+     cholmod_sparse *A,
+-    const ParU_Symbolic Sym     // symbolic analysis
++    // gcc on Alma 8 actually errors out on line 443:
++    // error: "Sym" is predetermined "shared" for "shared"
++    // It's dumb to error out when the programmer just restates a default,
++    // but some extant versions of gcc do this, while others (and clang)
++    // error out if Sym is not included in the shared list.  Removing
++    // default(none) is risky, as behavior may differ with different
++    // compilers.  Since the code is confirmed to build on most platforms
++    // with const Sym, we know that nothing is trying to modify Sym after,
++    // so removing the const should not cause any problems.
++    // const ParU_Symbolic Sym     // symbolic analysis
++    ParU_Symbolic Sym     // symbolic analysis
+ )
+ {
+