CVS commit: pkgsrc/www/firefox

["Ryo ONODERA" <ryoon%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   ryoon
Date:           Wed Dec 25 13:30:11 UTC 2024

Modified Files:
        pkgsrc/www/firefox: Makefile distinfo
        pkgsrc/www/firefox/patches: patch-nsprpub_pr_src_pthreads_ptsynch.c
Removed Files:
        pkgsrc/www/firefox/patches:
            patch-python_mozbuild_mozbuild_action_node.py
            patch-third__party_libwebrtc_build_android_apk__operations.py
            patch-third__party_libwebrtc_build_android_gyp_util_build__utils.py
            patch-third__party_libwebrtc_build_chromeos_test__runner.py
            patch-third__party_libwebrtc_build_env__dump.py
            patch-third__party_libwebrtc_build_print__python__deps.py
            patch-third__party_libwebrtc_build_vs__toolchain.py

Log Message:
www/firefox: Update to 133.0.3

Changelog:
133.0.3:
Fixed

  * Fixed the missing scrollbar in the Library window, such as when viewing
    History or Bookmarks. (Bug 1934482)

  * Fixed a problem where toolbar buttons were not visible on mouseover when
    using both the Windows High Contrast theme and the Firefox System theme. (
    Bug 1930840)

  * Fixed blurry line drawing on some Canvas elements when hardware
    acceleration is enabled. (Bug 1933668)

  * Fixed incorrect Firefox window positioning on Windows when restoring from
    maximized. (Bug 1934238)

133.0:
New

  * Firefox now has a new anti-tracking feature, Bounce Tracking Protection,
    which is now available in Enhanced Tracking Protection's "Strict" mode.
    This feature detects bounce trackers based on their redirect behavior and
    periodically purges their cookies and site data to block tracking.

  * The sidebar to view tabs from other devices can now be opened via the Tab
    overview menu.

    screenshot of the Tab Overview menu showing the tabs from other devices
    menu entry

  * Canvas2D switched from Direct2D to a platform independent acceleration
    backend on Windows.

Fixed

  * Various security fixes.

  * The "Picture-in-Picture: auto-open on tab switch" feature from Firefox
    Labs now behaves more reliably across a wider range of sites, automatically
    opening relevant videos while ignoring others.

Changed

  * When server time is available, the "expire" attribute value is adjusted by
    adding the difference between the server and local times. If the current
    time is set in the future, cookies that have not expired according to the
    server time are considered valid.

Security fixes:
Mozilla Foundation Security Advisory 2024-63
#CVE-2024-11691: Out-of-bounds write in Apple GPU drivers via WebGL
#CVE-2024-11700: Potential Tapjacking Exploit for Intent Confirmation on
 Android
#CVE-2024-11692: Select list elements could be shown over another site
#CVE-2024-11701: Misleading Address Bar State During Navigation Interruption
#CVE-2024-11702: Inadequate Clipboard Protection in Private Browsing Mode on
 Android
#CVE-2024-11693: Download Protections were bypassed by .library-ms files on
 Windows
#CVE-2024-11694: CSP Bypass and XSS Exposure via Web Compatibility Shims
#CVE-2024-11695: URL Bar Spoofing via Manipulated Punycode and Whitespace
 Characters
#CVE-2024-11703: Password access without authentication via PIN bypass on
 Android
#CVE-2024-11696: Unhandled Exception in Add-on Signature Verification
#CVE-2024-11697: Improper Keypress Handling in Executable File Confirmation
 Dialog
#CVE-2024-11704: Potential Double-Free Vulnerability in PKCS#7 Decryption
 Handling
#CVE-2024-11698: Fullscreen Lock-Up When Modal Dialog Interrupts Transition on
 macOS
#CVE-2024-11705: Null Pointer Dereference in NSC_DeriveKey
#CVE-2024-11706: Null Pointer Dereference in PKCS#12 Utility
#CVE-2024-11708: Data race with PlaybackParams
#CVE-2024-11699: Memory safety bugs fixed in Firefox 133, Firefox ESR 128.5,
 and Thunderbird 128.5


To generate a diff of this commit:
cvs rdiff -u -r1.619 -r1.620 pkgsrc/www/firefox/Makefile
cvs rdiff -u -r1.547 -r1.548 pkgsrc/www/firefox/distinfo
cvs rdiff -u -r1.2 -r1.3 \
    pkgsrc/www/firefox/patches/patch-nsprpub_pr_src_pthreads_ptsynch.c
cvs rdiff -u -r1.1 -r0 \
    pkgsrc/www/firefox/patches/patch-python_mozbuild_mozbuild_action_node.py \
    pkgsrc/www/firefox/patches/patch-third__party_libwebrtc_build_android_apk__operations.py \
    pkgsrc/www/firefox/patches/patch-third__party_libwebrtc_build_android_gyp_util_build__utils.py \
    pkgsrc/www/firefox/patches/patch-third__party_libwebrtc_build_chromeos_test__runner.py \
    pkgsrc/www/firefox/patches/patch-third__party_libwebrtc_build_env__dump.py \
    pkgsrc/www/firefox/patches/patch-third__party_libwebrtc_build_print__python__deps.py \
    pkgsrc/www/firefox/patches/patch-third__party_libwebrtc_build_vs__toolchain.py

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/www/firefox/Makefile
diff -u pkgsrc/www/firefox/Makefile:1.619 pkgsrc/www/firefox/Makefile:1.620
--- pkgsrc/www/firefox/Makefile:1.619   Fri Nov 22 14:54:42 2024
+++ pkgsrc/www/firefox/Makefile Wed Dec 25 13:30:10 2024
@@ -1,8 +1,8 @@
-# $NetBSD: Makefile,v 1.619 2024/11/22 14:54:42 ryoon Exp $
+# $NetBSD: Makefile,v 1.620 2024/12/25 13:30:10 ryoon Exp $
 
 FIREFOX_VER=           ${MOZ_BRANCH}${MOZ_BRANCH_MINOR}
-MOZ_BRANCH=            132.0
-MOZ_BRANCH_MINOR=      .2
+MOZ_BRANCH=            133.0
+MOZ_BRANCH_MINOR=      .3
 
 DISTNAME=      firefox-${FIREFOX_VER}.source
 PKGNAME=       ${DISTNAME:S/.source//:S/b/beta/:S/esr//}

Index: pkgsrc/www/firefox/distinfo
diff -u pkgsrc/www/firefox/distinfo:1.547 pkgsrc/www/firefox/distinfo:1.548
--- pkgsrc/www/firefox/distinfo:1.547   Fri Nov 22 14:54:42 2024
+++ pkgsrc/www/firefox/distinfo Wed Dec 25 13:30:10 2024
@@ -1,8 +1,8 @@
-$NetBSD: distinfo,v 1.547 2024/11/22 14:54:42 ryoon Exp $
+$NetBSD: distinfo,v 1.548 2024/12/25 13:30:10 ryoon Exp $
 
-BLAKE2s (firefox-132.0.2.source.tar.xz) = 9f3a645cd26edb7fb6fc830138a15752fc8819b390fe1a437555bd8b3b8f514c
-SHA512 (firefox-132.0.2.source.tar.xz) = 9ea95d9fb1a941ac5a5b50da67e224f3ccf8c401f26cb61bb74ad7f4e1e8706d469c4b6325714f2cb9cdf50c32710377d6bca18dd65b55db2c39ef2b27a57fae
-Size (firefox-132.0.2.source.tar.xz) = 570535648 bytes
+BLAKE2s (firefox-133.0.3.source.tar.xz) = 92b62c1a1fa8e7034cbefbf470e8d40fbc75a542a00ff78f07fe2a0e9ab875ac
+SHA512 (firefox-133.0.3.source.tar.xz) = ce48beaa5bb1717d9b6dbfff035b1bb5de1456df14b6a91adfaf3ccfb7ac550ab7ee854546231424a920e01d981825253609fce2ec326c4aa1ca316bbbdb31f8
+Size (firefox-133.0.3.source.tar.xz) = 580071280 bytes
 BLAKE2s (nodejs-output-132.0.tgz) = df80a8b098b4d9eb831e249054acf45b7ea5e3d9797782515819532490d83153
 SHA512 (nodejs-output-132.0.tgz) = 9af2e28ad6f02606c3b2ba8a07dbb813d80a88088092d76e474220d9db2c963f22d0d98f3e58b2a275d7ceb84ba8de55e9ae5e7f65f6bd9b61667c3237dcc3f0
 Size (nodejs-output-132.0.tgz) = 242465 bytes
@@ -30,18 +30,11 @@ SHA1 (patch-media_ffvpx_libavutil_arm_bs
 SHA1 (patch-media_libpng_pngpriv.h) = 8320a1f7534ed5c4914b597bb3d6117d0060318f
 SHA1 (patch-modules_fdlibm_src_math__private.h) = e20b6c23011d7123cbbd64a500eb8ce8c426620e
 SHA1 (patch-netwerk_protocol_http_nsHttpHandler.cpp) = ff6df620e9da46d58350e8330e31b345dd867e99
-SHA1 (patch-nsprpub_pr_src_pthreads_ptsynch.c) = b0d1f6a6e0eb852b0fd0238ad3f8ed3166c60a50
-SHA1 (patch-python_mozbuild_mozbuild_action_node.py) = eece38efe4ee1eb51de6cca89fa1c479ef02d60c
+SHA1 (patch-nsprpub_pr_src_pthreads_ptsynch.c) = 753fd4d62088c870aefe7c4b739286259848446e
 SHA1 (patch-python_mozbuild_mozbuild_backend_recursivemake.py) = 5be4183d9075f5a3a3c6b3e0338473af185fb50e
 SHA1 (patch-testing_mozbase_mozdevice_mozdevice_adb.py) = 14d5107ce2c945d8b8d60a8edc968443a9970291
 SHA1 (patch-testing_xpcshell_runxpcshelltests.py) = 1c42e8794da0bdd6248bd53d1450b982616aa536
 SHA1 (patch-third__party_js_cfworker_build.sh) = 46cdf97b99cf01080f290ae8d9a33b5f869fc3e4
-SHA1 (patch-third__party_libwebrtc_build_android_apk__operations.py) = a74d8c87746420f29d1be49af6a5c5e191897e3f
-SHA1 (patch-third__party_libwebrtc_build_android_gyp_util_build__utils.py) = aaf39184e25aa3f97c02dd29c4877e0f9b172063
-SHA1 (patch-third__party_libwebrtc_build_chromeos_test__runner.py) = 36f902daff9d98bcbd12c725ee49373e583f6cd5
-SHA1 (patch-third__party_libwebrtc_build_env__dump.py) = a8cdb9fc5baf15454019f9011fafa1d5967f9eda
-SHA1 (patch-third__party_libwebrtc_build_print__python__deps.py) = cbb5917cc9d82f3a0d16684dff1ecee3e83e0f56
-SHA1 (patch-third__party_libwebrtc_build_vs__toolchain.py) = 265412d8da2497c1e8893edfaf5d78abf96620df
 SHA1 (patch-third__party_libwebrtc_modules_desktop__capture_desktop__capture__gn_moz.build) = d0454784eb72be49162f619579e060a0de3c480f
 SHA1 (patch-third__party_libwebrtc_modules_desktop__capture_linux_wayland_egl__dmabuf.cc) = 455be625b5de2f6f1f4b2dbb6c8cb33ca16c2583
 SHA1 (patch-third__party_libwebrtc_modules_video__capture_linux_device__info__v4l2.cc) = 4cb0e1c88dc83370024ed1aac7f75445b9f98df8

Index: pkgsrc/www/firefox/patches/patch-nsprpub_pr_src_pthreads_ptsynch.c
diff -u pkgsrc/www/firefox/patches/patch-nsprpub_pr_src_pthreads_ptsynch.c:1.2 pkgsrc/www/firefox/patches/patch-nsprpub_pr_src_pthreads_ptsynch.c:1.3
--- pkgsrc/www/firefox/patches/patch-nsprpub_pr_src_pthreads_ptsynch.c:1.2      Tue Jan 24 18:06:12 2023
+++ pkgsrc/www/firefox/patches/patch-nsprpub_pr_src_pthreads_ptsynch.c  Wed Dec 25 13:30:11 2024
@@ -1,4 +1,4 @@
-$NetBSD: patch-nsprpub_pr_src_pthreads_ptsynch.c,v 1.2 2023/01/24 18:06:12 nia Exp $
+$NetBSD: patch-nsprpub_pr_src_pthreads_ptsynch.c,v 1.3 2024/12/25 13:30:11 ryoon Exp $
 
 firefox: Workaround broken pthread_equal() usage
 
@@ -8,11 +8,11 @@ Problems detected on NetBSD 9.99.46.
 
 https://bugzilla.mozilla.org/show_bug.cgi?id=1718838
 
---- nsprpub/pr/src/pthreads/ptsynch.c.orig     2020-01-17 21:34:42.000000000 +0000
+--- nsprpub/pr/src/pthreads/ptsynch.c.orig     2024-11-25 14:49:12.865195781 +0000
 +++ nsprpub/pr/src/pthreads/ptsynch.c
 @@ -25,6 +25,13 @@ static pthread_condattr_t _pt_cvar_attr;
- extern PTDebug pt_debug;  /* this is shared between several modules */
- #endif  /* defined(DEBUG) */
+ extern PTDebug pt_debug; /* this is shared between several modules */
+ #  endif                 /* defined(DEBUG) */
  
 +/* XXX, pthread_equal() is misused to compare non-valid thread pointers */
 +static int
@@ -21,92 +21,92 @@ https://bugzilla.mozilla.org/show_bug.cg
 +      return t1 == t2;
 +}
 +
- #if defined(FREEBSD)
+ #  if defined(FREEBSD)
  /*
   * On older versions of FreeBSD, pthread_mutex_trylock returns EDEADLK.
-@@ -197,9 +204,9 @@ PR_IMPLEMENT(PRStatus) PR_Unlock(PRLock 
-     PR_ASSERT(lock != NULL);
-     PR_ASSERT(_PT_PTHREAD_MUTEX_IS_LOCKED(lock->mutex));
-     PR_ASSERT(PR_TRUE == lock->locked);
--    PR_ASSERT(pthread_equal(lock->owner, self));
-+    PR_ASSERT(pt_pthread_equal(lock->owner, self));
- 
--    if (!lock->locked || !pthread_equal(lock->owner, self)) {
-+    if (!lock->locked || !pt_pthread_equal(lock->owner, self)) {
-         return PR_FAILURE;
-     }
- 
-@@ -225,7 +232,7 @@ PR_IMPLEMENT(void) PR_AssertCurrentThrea
-      * to the correctness of PR_AssertCurrentThreadOwnsLock(), but
-      * this particular order makes the assertion more likely to
-      * catch errors. */
--    PR_ASSERT(lock->locked && pthread_equal(lock->owner, pthread_self()));
-+    PR_ASSERT(lock->locked && pt_pthread_equal(lock->owner, pthread_self()));
+@@ -181,9 +188,9 @@ PR_IMPLEMENT(PRStatus) PR_Unlock(PRLock*
+   PR_ASSERT(lock != NULL);
+   PR_ASSERT(_PT_PTHREAD_MUTEX_IS_LOCKED(lock->mutex));
+   PR_ASSERT(PR_TRUE == lock->locked);
+-  PR_ASSERT(pthread_equal(lock->owner, self));
++  PR_ASSERT(pt_pthread_equal(lock->owner, self));
+ 
+-  if (!lock->locked || !pthread_equal(lock->owner, self)) {
++  if (!lock->locked || !pt_pthread_equal(lock->owner, self)) {
+     return PR_FAILURE;
+   }
+ 
+@@ -207,7 +214,7 @@ PR_IMPLEMENT(void) PR_AssertCurrentThrea
+    * to the correctness of PR_AssertCurrentThreadOwnsLock(), but
+    * this particular order makes the assertion more likely to
+    * catch errors. */
+-  PR_ASSERT(lock->locked && pthread_equal(lock->owner, pthread_self()));
++  PR_ASSERT(lock->locked && pt_pthread_equal(lock->owner, pthread_self()));
  }
  
  /**************************************************************/
-@@ -281,7 +288,7 @@ static void pt_PostNotifyToCvar(PRCondVa
-     _PT_Notified *notified = &cvar->lock->notified;
+@@ -260,7 +267,7 @@ static void pt_PostNotifyToCvar(PRCondVa
+   _PT_Notified* notified = &cvar->lock->notified;
  
-     PR_ASSERT(PR_TRUE == cvar->lock->locked);
--    PR_ASSERT(pthread_equal(cvar->lock->owner, pthread_self()));
-+    PR_ASSERT(pt_pthread_equal(cvar->lock->owner, pthread_self()));
-     PR_ASSERT(_PT_PTHREAD_MUTEX_IS_LOCKED(cvar->lock->mutex));
- 
-     while (1)
-@@ -369,7 +376,7 @@ PR_IMPLEMENT(PRStatus) PR_WaitCondVar(PR
-     PR_ASSERT(_PT_PTHREAD_MUTEX_IS_LOCKED(cvar->lock->mutex));
-     PR_ASSERT(PR_TRUE == cvar->lock->locked);
-     /* and it better be by us */
--    PR_ASSERT(pthread_equal(cvar->lock->owner, pthread_self()));
-+    PR_ASSERT(pt_pthread_equal(cvar->lock->owner, pthread_self()));
- 
-     if (_PT_THREAD_INTERRUPTED(thred)) {
-         goto aborted;
-@@ -582,7 +589,7 @@ PR_IMPLEMENT(PRIntn) PR_GetMonitorEntryC
- 
-     rv = pthread_mutex_lock(&mon->lock);
-     PR_ASSERT(0 == rv);
+   PR_ASSERT(PR_TRUE == cvar->lock->locked);
+-  PR_ASSERT(pthread_equal(cvar->lock->owner, pthread_self()));
++  PR_ASSERT(pt_pthread_equal(cvar->lock->owner, pthread_self()));
+   PR_ASSERT(_PT_PTHREAD_MUTEX_IS_LOCKED(cvar->lock->mutex));
+ 
+   while (1) {
+@@ -336,7 +343,7 @@ PR_IMPLEMENT(PRStatus) PR_WaitCondVar(PR
+   PR_ASSERT(_PT_PTHREAD_MUTEX_IS_LOCKED(cvar->lock->mutex));
+   PR_ASSERT(PR_TRUE == cvar->lock->locked);
+   /* and it better be by us */
+-  PR_ASSERT(pthread_equal(cvar->lock->owner, pthread_self()));
++  PR_ASSERT(pt_pthread_equal(cvar->lock->owner, pthread_self()));
+ 
+   if (_PT_THREAD_INTERRUPTED(thred)) {
+     goto aborted;
+@@ -535,7 +542,7 @@ PR_IMPLEMENT(PRIntn) PR_GetMonitorEntryC
+ 
+   rv = pthread_mutex_lock(&mon->lock);
+   PR_ASSERT(0 == rv);
+-  if (pthread_equal(mon->owner, self)) {
++  if (pt_pthread_equal(mon->owner, self)) {
+     count = mon->entryCount;
+   }
+   rv = pthread_mutex_unlock(&mon->lock);
+@@ -549,7 +556,7 @@ PR_IMPLEMENT(void) PR_AssertCurrentThrea
+ 
+   rv = pthread_mutex_lock(&mon->lock);
+   PR_ASSERT(0 == rv);
+-  PR_ASSERT(mon->entryCount != 0 && pthread_equal(mon->owner, pthread_self()));
++  PR_ASSERT(mon->entryCount != 0 && pt_pthread_equal(mon->owner, pthread_self()));
+   rv = pthread_mutex_unlock(&mon->lock);
+   PR_ASSERT(0 == rv);
+ #  endif
+@@ -563,7 +570,7 @@ PR_IMPLEMENT(void) PR_EnterMonitor(PRMon
+   rv = pthread_mutex_lock(&mon->lock);
+   PR_ASSERT(0 == rv);
+   if (mon->entryCount != 0) {
 -    if (pthread_equal(mon->owner, self)) {
 +    if (pt_pthread_equal(mon->owner, self)) {
-         count = mon->entryCount;
+       goto done;
      }
+     while (mon->entryCount != 0) {
+@@ -593,8 +600,8 @@ PR_IMPLEMENT(PRStatus) PR_ExitMonitor(PR
+   PR_ASSERT(0 == rv);
+   /* the entries should be > 0 and we'd better be the owner */
+   PR_ASSERT(mon->entryCount > 0);
+-  PR_ASSERT(pthread_equal(mon->owner, self));
+-  if (mon->entryCount == 0 || !pthread_equal(mon->owner, self)) {
++  PR_ASSERT(pt_pthread_equal(mon->owner, self));
++  if (mon->entryCount == 0 || !pt_pthread_equal(mon->owner, self)) {
      rv = pthread_mutex_unlock(&mon->lock);
-@@ -598,7 +605,7 @@ PR_IMPLEMENT(void) PR_AssertCurrentThrea
-     rv = pthread_mutex_lock(&mon->lock);
-     PR_ASSERT(0 == rv);
-     PR_ASSERT(mon->entryCount != 0 &&
--              pthread_equal(mon->owner, pthread_self()));
-+              pt_pthread_equal(mon->owner, pthread_self()));
-     rv = pthread_mutex_unlock(&mon->lock);
-     PR_ASSERT(0 == rv);
- #endif
-@@ -614,7 +621,7 @@ PR_IMPLEMENT(void) PR_EnterMonitor(PRMon
-     PR_ASSERT(0 == rv);
-     if (mon->entryCount != 0)
-     {
--        if (pthread_equal(mon->owner, self)) {
-+        if (pt_pthread_equal(mon->owner, self)) {
-             goto done;
-         }
-         while (mon->entryCount != 0)
-@@ -646,8 +653,8 @@ PR_IMPLEMENT(PRStatus) PR_ExitMonitor(PR
      PR_ASSERT(0 == rv);
-     /* the entries should be > 0 and we'd better be the owner */
-     PR_ASSERT(mon->entryCount > 0);
--    PR_ASSERT(pthread_equal(mon->owner, self));
--    if (mon->entryCount == 0 || !pthread_equal(mon->owner, self))
-+    PR_ASSERT(pt_pthread_equal(mon->owner, self));
-+    if (mon->entryCount == 0 || !pt_pthread_equal(mon->owner, self))
-     {
-         rv = pthread_mutex_unlock(&mon->lock);
-         PR_ASSERT(0 == rv);
-@@ -695,7 +702,7 @@ PR_IMPLEMENT(PRStatus) PR_Wait(PRMonitor
-     /* the entries better be positive */
-     PR_ASSERT(mon->entryCount > 0);
-     /* and it better be owned by us */
--    PR_ASSERT(pthread_equal(mon->owner, pthread_self()));
-+    PR_ASSERT(pt_pthread_equal(mon->owner, pthread_self()));
+     return PR_FAILURE;
+@@ -638,7 +645,7 @@ PR_IMPLEMENT(PRStatus) PR_Wait(PRMonitor
+   /* the entries better be positive */
+   PR_ASSERT(mon->entryCount > 0);
+   /* and it better be owned by us */
+-  PR_ASSERT(pthread_equal(mon->owner, pthread_self()));
++  PR_ASSERT(pt_pthread_equal(mon->owner, pthread_self()));
  
-     /* tuck these away 'till later */
-     saved_entries = mon->entryCount;
+   /* tuck these away 'till later */
+   saved_entries = mon->entryCount;