Subject: Re: [PATCH] centericq: Fix Jabber plugin, make gpgme optional
To: Jonathan Schleifer <js@h3c.de>
From: Stephen Borrill <netbsd@precedence.co.uk>
List: pkgsrc-users
Date: 02/20/2007 17:19:52
On Mon, 19 Feb 2007, Jonathan Schleifer wrote:
> This patch makes gpgme an optional in centericq.
Sounds good - I was going to do that myself.
> Additionally, this removes a deprecated request from the Jabber plugin
> so that it works with ejabberd servers.
>
> --- src/hooks/jabberhook.cc.orig 2007-02-19 15:08:26.000000000 +0100
> +++ src/hooks/jabberhook.cc 2007-02-19 15:08:38.000000000 +0100
> @@ -887,11 +887,6 @@
> void jabberhook::gotloggedin() {
> xmlnode x;
>
> - x = jutil_iqnew(JPACKET__GET, NS_AGENTS);
> - xmlnode_put_attrib(x, "id", "Agent List");
> - jab_send(jc, x);
> - xmlnode_free(x);
> -
> x = jutil_iqnew(JPACKET__GET, NS_ROSTER);
> xmlnode_put_attrib(x, "id", "Roster");
> jab_send(jc, x);
>
> Please test & commit.
I'm happy to commit the option part, but could you point me at some
documentation about the NS_AGENTS being deprecated? Might it be better to
stop ejabberd failing when faced with such a thing?
--
Stephen