Hi Joel.  I hope you aren't interpreting the terseness of my reply
to indicate expertise on my part :-)

But I think you should be able to back out your patch entirely,
and just defining your browser as `firefox' should be sufficient.
I'm about to try it myself, but even at a 100k/s, it's a sloooow
download.

Brian.

On 2007.03.15 22:24:12 +0100, Joel CARNAT wrote:
> OK. Do you know a pkgsrc example of such a thing ?
> Because I looked at gcc and python and didn't understood how to handle
> both version. Should it be handle like www/firefox-bin and its
> MOZILLA_USE_LINUX variable ?
> 
> TIA,
> 	Jo
> 
> On Thu, Mar 15 2007 - 14:27, Brian de Alwis wrote:
> > www/firefox2/buildlink3.mk was a mistake and should be removed.
> > www/firefox/buildlink3.mk should handle both firefox 1.X and 2.X.
> > 
> > Brian.
> > 
> > On 2007.03.15 14:41:22 +0100, Joel CARNAT wrote:
> > > Hi,
> > > 
> > > as I am already using www/firefox2, I modified misc/openoffice2 files as
> > > follow:
> > > *****************************************************************
> > > --- options.mk.orig     2007-03-13 21:16:51.000000000 +0100
> > > +++ options.mk  2007-03-13 21:22:36.000000000 +0100
> > > @@ -4,5 +4,5 @@
> > >  PKG_SUPPORTED_OPTIONS=         cups gnome gtk2 # kde
> > >  PKG_OPTIONS_REQUIRED_GROUPS=   browser lang
> > > -PKG_OPTIONS_GROUP.browser=     firefox firefox-gtk1 seamonkey seamonkey-gtk1
> > > +PKG_OPTIONS_GROUP.browser=     firefox firefox2 firefox-gtk1 seamonkey
> > > seamonkey-gtk1
> > >  OO_SUPPORTED_LANGUAGES=                en-US af as-IN be-BY bg br bs ca
> > > cs cy da de \
> > >                                 el en-GB en-ZA eo es et fa fi fr ga gu-IN
> > > he \
> > > @@ -28,4 +28,9 @@
> > >  .endif
> > > 
> > > +.if !empty(PKG_OPTIONS:Mfirefox2)
> > > +.include "../../www/firefox2/buildlink3.mk"
> > > +CONFIGURE_ARGS+=       --with-system-mozilla --with-firefox
> > > +.endif
> > > +
> > >  .if !empty(PKG_OPTIONS:Mfirefox-gtk1)
> > >  .include "../../www/firefox-gtk1/buildlink3.mk"
> > > *****************************************************************
> > > 
> > > When compilling OOo, I get the following error:
> > > => Required installed package firefox2>=2.0: NOT found
> > > => Verifying package for ../../www/firefox2
> > > ERROR: [depends.mk] A package matching ``firefox2>=2.0'' should
> > > ERROR:     be installed, but one cannot be found.  Perhaps there is a
> > > ERROR:     stale work directory for ../../www/firefox2?
> > > *** Error code 1
> > > 
> > > Stop.
> > > make: stopped in /home/cvs/pkgsrc/misc/openoffice2
> > > *** Error code 1
> > > 
> > > This seem to be because www/firefox2 is registered as firefox-2.x:
> > > #  pkg_info | grep firefox
> > > firefox-2.0.0.2     Lightweight gecko-based web browser
> > > 
> > > I'm not sure what has to be modified (and how).
> > > >From what I understood buildlink3 refers to firefox2 but Makefile refers
> > > to www/firefox. Is it www/firefox2/buildlink3.mk file or
> > > www/firefox2/Makefile ?
> > > 
> > > TIA,
> > >      Jo
> > 
> > -- 
> >   Brian de Alwis | Software Practices Lab | UBC | http://www.cs.ubc.ca/~bsd/
> >       "Amusement to an observing mind is study." - Benjamin Disraeli



-- 
  Brian de Alwis | Software Practices Lab | UBC | http://www.cs.ubc.ca/~bsd/
      "Amusement to an observing mind is study." - Benjamin Disraeli