Subject: devel/libgphoto2/patches/patch-aa has unbalanced parentheses
To: pkgsrc-user MailingList <pkgsrc-users@netbsd.org>
From: Erik Bertelsen <bertelsen.erik@gmail.com>
List: pkgsrc-users
Date: 03/19/2007 17:01:36
Looking at patch-aa for libgphoto2 rev 1.5 the following lines don't compile:

@@ -3696,8 +3697,12 @@

        curloc = nl_langinfo (CODESET);
        if (!curloc) curloc="UTF-8";
-       camera->pl->params.cd_ucs2_to_locale = iconv_open(curloc,
UCS_2_INTERNAL);
-       camera->pl->params.cd_locale_to_ucs2 =
iconv_open(UCS_2_INTERNAL, curloc);
+       camera->pl->params.cd_ucs2_to_locale = iconv_open(curloc,
"UCS-2-INTERNAL");
+       if(camera->pl->params.cd_ucs2_to_locale == (iconv_t) -1))
    ^^
+               camera->pl->params.cd_ucs2_to_locale =
iconv_open(curloc, "UCS-2");
+       camera->pl->params.cd_locale_to_ucs2 =
iconv_open("UCS-2-INTERNAL", curloc);
+       if(camera->pl->params.cd_locale_to_ucs2 == (iconv_t) -1))
    ^^
+               camera->pl->params.cd_locale_to_ucs2 =
iconv_open("UCS-2", curloc);
        if ((camera->pl->params.cd_ucs2_to_locale == (iconv_t) -1) ||
            (camera->pl->params.cd_locale_to_ucs2 == (iconv_t) -1)) {
                gp_log (GP_LOG_ERROR, "iconv", "Failed to create iconv
converter.\n");


The problem is that the two lines marked above has an extra ) at the end.

- Erik