"Jeremy C. Reed" <reed@reedmedia.net> writes:

> I moved this to pkgsrc-users.
>
> On Wed, 21 Mar 2007, Greg Troxel wrote:
>
>> For mplayer, the problems are:
>> 
>> NO_BIN_ON_CDROM=        a dependency is restricted
>> NO_BIN_ON_FTP=          a dependency is restricted
>> NO_SRC_ON_FTP=          prohibited by USAs DMCA

> If I looked correctly, this is libdca (dts) and maybe the internal faad.
> I wonder if mplayer supports any plugin to add libdca support.

Plugins are definitely the way to go for layer 9 problems.  That way
the base package can avoid packages with license issues and those
people who either have licenses or are in jurisdictions where they
aren't needed can add the plugins, without having to rebuild.

> Does anyone know or care if the NO_BIN_ON_CDROM and NO_BIN_ON_FTP is 
> removed by not including libdca by default?

Also win32-codecs and realplayer-codecs should be disabled by default.
I'm in favor of disabling any such options by default as long as the
resulting binary package can be distributed and will still be somewhat
useful.  Given that there's no maintainer, I'm going to adjust the
default options.

With the following uncommitted diff, and the resulting mplayer plays
a .avi fine.

Index: mplayer/DESCR
===================================================================
RCS file: /cvsroot/pkgsrc/multimedia/mplayer/DESCR,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 DESCR
--- mplayer/DESCR	26 Jan 2004 12:08:12 -0000	1.1.1.1
+++ mplayer/DESCR	22 Mar 2007 13:56:43 -0000
@@ -12,3 +12,6 @@ enjoy movies in fullscreen. It also spor
 shaded subtitles (10 supported types) with european/ISO 8859-1,
 2 (hungarian, english, czech, etc), cyrillic, korean fonts, and
 OSD.
+
+The default build omits many codecs for licensing reasons; examine the
+options.
Index: mplayer/Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/multimedia/mplayer/Makefile,v
retrieving revision 1.41
diff -u -p -r1.41 Makefile
--- mplayer/Makefile	9 Mar 2007 15:14:16 -0000	1.41
+++ mplayer/Makefile	22 Mar 2007 13:56:43 -0000
@@ -1,9 +1,9 @@
 # $NetBSD: Makefile,v 1.41 2007/03/09 15:14:16 drochner Exp $
 
 PKGNAME=	mplayer-${MPLAYER_PKG_VERSION}
-PKGREVISION=	5
+PKGREVISION=	6
 
-COMMENT=	Software-only MPEG-1/2/4 video decoder
+COMMENT=	Software-only multiformat video decoder
 
 .include "../../multimedia/mplayer-share/Makefile.common"
 
Index: mplayer-share/options.mk
===================================================================
RCS file: /cvsroot/pkgsrc/multimedia/mplayer-share/options.mk,v
retrieving revision 1.20
diff -u -p -r1.20 options.mk
--- mplayer-share/options.mk	27 Dec 2006 21:14:12 -0000	1.20
+++ mplayer-share/options.mk	22 Mar 2007 13:56:43 -0000
@@ -24,7 +24,8 @@ PKG_SUPPORTED_OPTIONS=	gif jpeg mad dts 
 .if !empty(PKGNAME:M*mplayer*)
 PKG_OPTIONS_OPTIONAL_GROUPS=	faadgroup
 PKG_OPTIONS_GROUP.faadgroup=	faad mplayer-internal-faad
-PKG_SUGGESTED_OPTIONS+=		mplayer-internal-faad
+# faad appears to have patent issues; do not enable by default
+# PKG_SUGGESTED_OPTIONS+=		mplayer-internal-faad
 
 PKG_SUPPORTED_OPTIONS+=	aalib esound ggi mplayer-menu nas sdl
 
@@ -58,9 +59,10 @@ PKG_SUPPORTED_OPTIONS+=	mplayer-real
 # Define PKG_SUGGESTED_OPTIONS.
 # -------------------------------------------------------------------------
 
+# Omit due to license issues: mplayer-real mplayer-win32
 .for _o_ in aalib arts cdparanoia dv dvdread esound gif jpeg \
-	    lame mad mplayer-menu mplayer-real \
-	    mplayer-runtime-cpudetection mplayer-win32 \
+	    lame mad mplayer-menu \
+	    mplayer-runtime-cpudetection \
 	    nas oss png sdl theora vorbis xvid
 .  if !empty(PKG_SUPPORTED_OPTIONS:M${_o_})
 PKG_SUGGESTED_OPTIONS+=	${_o_}