Re: rust and new thunderbird

[Chavdar Ivanov <ci4ic4%gmail.com@localhost>]

FWIW, on a 10.99.7 NetBSD 10.99.7 (GENERIC) #4: Sun Aug 20 (amd64)

building mail/thunderbird 102.8.0 p2

using wip/rust 1.71 (built a few hours ago)

I am getting:
.....
error[E0277]: cannot multiply `u64` by `NonZeroU8`
    --> /usr/pkgsrc/mail/thunderbird/work/thunderbird-102.8.0/third_party/rust/mp4parse/src/lib.rs:3188:62
     |
3188 |                 static_assertions::const_assert!(<$lhs>::MAX *
<$rhs>::MAX <= <$output>::MAX);
     |                                                              ^
no implementation for `u64 * NonZeroU8`
...
3198 | impl_mul!((U8, std::num::NonZeroU8) => (U16, u16));
     | -------------------------------------------------- in this
macro invocation
     |
     = help: the trait `Mul<NonZeroU8>` is not implemented for `u64`
     = help: the following other types implement trait `Mul<Rhs>`:
               <&'a u64 as Mul<u64>>
               <&u64 as Mul<&u64>>
               <u64 as Mul<&u64>>
               <u64 as Mul>
     = note: this error originates in the macro `impl_mul` (in Nightly
builds, run with -Z macro-backtrace for more info)

error[E0277]: cannot multiply `u64` by `NonZeroU8`
    --> /usr/pkgsrc/mail/thunderbird/work/thunderbird-102.8.0/third_party/rust/mp4parse/src/lib.rs:3188:62
     |
3188 |                 static_assertions::const_assert!(<$lhs>::MAX *
<$rhs>::MAX <= <$output>::MAX);
     |                                                              ^
no implementation for `u64 * NonZeroU8`
...
3199 | impl_mul!((U32, std::num::NonZeroU8) => (U32MulU8, u64));
     | -------------------------------------------------------- in
this macro invocation
     |
     = help: the trait `Mul<NonZeroU8>` is not implemented for `u64`
     = help: the following other types implement trait `Mul<Rhs>`:
               <&'a u64 as Mul<u64>>
               <&u64 as Mul<&u64>>
               <u64 as Mul<&u64>>
               <u64 as Mul>
     = note: this error originates in the macro `impl_mul` (in Nightly
builds, run with -Z macro-backtrace for more info)

For more information about this error, try `rustc --explain E0277`.
error: could not compile `mp4parse` (lib) due to 2 previous errors
....

Rust is black magic for me, so no idea...

I also tried to build wip/thunderbird, but this failed on patch phase.

Chavdar

On Mon, 28 Aug 2023 at 19:02, Havard Eidnes <he%netbsd.org@localhost> wrote:
>
> > We have similar patches in the tree for other packages, but it's better
> > to just put a single "using std::isnan;" at the top of the file if that
> > works as well. Causes less merge headaches down the road.
>
> Thanks for the hint.  Committed after a build verification.
>
> Regards,
>
> - Håvard



-- 
----