Re: Add options to KeePassXC

[Greg Troxel <gdt%lexort.com@localhost>]

Joel Carnat <joel%carnat.net@localhost> writes:

> On Mon, Feb 10, 2025 at 11:43:12AM GMT, Greg Troxel wrote:
>> Are any of these options something that should just always be on?  In
>> general, having options is bad, but it's also bad to be missing features
>> and to depend on things that don't need depending on.
>> 
>> I'm not seeing any bl3 included with the options, so I don't see what's
>> gained with having them off.
>> 
>> (I do understand that yubikey adds a dependency on pscs-lite, and
>> therefore that this is probably not desirable in general.)
>
> I don't know. I'm just used to having access to those when using
> OpenBSD or SlackBuilds and noticed they were not available there; so I
> just made them available.

OK,but let's figure it out before randomly adding options that really
should not exist.

>
> OpenBSD has only two FLAVORS: browser and yubikey.
> The browser flavor enables XC_BROWSER, XC_NETWORKING and
> XC_BROWSER_PASSKEY. SSHAGENT, FDOSECRETS and KEESHARE are ON by default.
>
> On SlackBuilds, all options are ON by default except YUBIKEY, DOCS and
> FDOSECRETS.

So that's a clue.  If enabling something doesn't require a dependency
that's big enough to hurt, and it doesn't hurt the user, it should just
be enabled, and not an option.

So it sounds like two options: browser and yubikey.  But browser only if
it adds dependencies or is significantly problematic.

Keep in mind that with standard binary packages, only the default
options are going to be available.   So the most important question is
how that should be.