Re: CVS commit: pkgsrc/wm/fluxbox

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Thu, Feb 27, 2025 at 04:18:26PM +0000, Nia Alarie wrote:
> Module Name:	pkgsrc
> Committed By:	nia
> Date:		Thu Feb 27 16:18:26 UTC 2025
> 
> Modified Files:
> 	pkgsrc/wm/fluxbox: options.mk
> 
> Log Message:
> fluxbox: Disable nls on SunOS due to issues with gencat
> 
> Found by drecklypkg ci, but also reported by peter tribble as being
> a problem with tribblix.

If the option doesn't work, shouldn't it be removed from
PKG_SUPPORTED_OPTIONS on that operating system instead?
 Thomas


> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.8 -r1.9 pkgsrc/wm/fluxbox/options.mk
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
> 

> Modified files:
> 
> Index: pkgsrc/wm/fluxbox/options.mk
> diff -u pkgsrc/wm/fluxbox/options.mk:1.8 pkgsrc/wm/fluxbox/options.mk:1.9
> --- pkgsrc/wm/fluxbox/options.mk:1.8	Sun Sep 20 13:30:45 2020
> +++ pkgsrc/wm/fluxbox/options.mk	Thu Feb 27 16:18:26 2025
> @@ -1,4 +1,4 @@
> -# $NetBSD: options.mk,v 1.8 2020/09/20 13:30:45 nia Exp $
> +# $NetBSD: options.mk,v 1.9 2025/02/27 16:18:26 nia Exp $
>  
>  PKG_OPTIONS_VAR=	PKG_OPTIONS.fluxbox
>  PKG_SUPPORTED_OPTIONS=	imlib2 xft2 xrender nls
> @@ -8,7 +8,9 @@ PKG_OPTIONS_LEGACY_OPTS+=	xft:xft2
>  
>  .include "../../mk/bsd.options.mk"
>  
> -.if ${OPSYS} != "MirBSD"
> +# SunOS has issues:
> +# gencat: "./generated-UTF-8.m", line 167: number or $ expected
> +.if ${OPSYS} != "MirBSD" && ${OPSYS} != "SunOS"
>  PKG_SUGGESTED_OPTIONS+=	nls
>  .endif
>  
>