Re: devel/hdf5-c++ and ninja

[Thomas Klausner <wiz%gatalith.at@localhost>]

On Wed, Mar 05, 2025 at 10:22:06AM -0500, Greg Troxel wrote:
> Following earlier advice, I have set
> 
>   CMAKE_GENERATOR?=		ninja
> 
> in mk.conf, and until today, that's been fine.
> 
> Building devel/hdf5-c++, it fails to find build.ninja, and it looks like
> confusion about
> 
>   BUILD_DIRS+=    c++
> 
> which is honored in part but apparently cmake/ninja doesn't know about
> that.

Yes, that can't work because it assumes that the necessary information
for a build is in c++.  That's only true for the recursive Makefile
structure cmake's Makefile generator produces.

For ninja, only a top-level build.ninja file is generated - it doesn't recurse.

So either find a build target for ninja that only builds the c++
subset of the package, and add logic to use one or the other in the
package Makefile, or override CMAKE_GENERATOR for that pkgsrc
Makefile.

I.e.

.include "../../mk/bsd.prefs.mk"
# building only a subdirectory using BUILD_DIRS is not supported with
# the ninja generator
CMAKE_GENERATOR=        make


 Thomas