Re: Rebuilding firefore

[Rob Whitlock <rwhitlock22%gmail.com@localhost>]

> On Apr 5, 2025, at 9:17 PM, David Holland <dholland-pkgusers%netbsd.org@localhost> wrote:
> 
> On Sat, Apr 05, 2025 at 10:34:00AM -0400, Rob Whitlock wrote:
>>> I think PKG_FAIL_REASON is the "backend" - it can be set for various
>>> reasons - and BROKEN is the "frontend" used for explicitly setting
>>> packages as broken in their package Makefiles.
>>> Thomas
>> 
>> The pkgsrc guide recommends setting it in certain situations
>> 
>>  If the package should be skipped (for example, because it
>>  provides functionality already provided by the system),
>>  set PKG_SKIP_REASON to a descriptive message. If the
>>  package should fail because some preconditions are not
>>  met, set PKG_FAIL_REASON to a descriptive message.
>> 
>> https://www.netbsd.org/docs/pkgsrc/fixes.html#not-building-packages
>> 
>> so I'm thinking maybe your explanation isn't entirely correct, or the
>> pkgsrc guide isn't correct.
> 
> BROKEN is a way to set PKG_FAIL_REASON, no more, no less.
> 
> .  if ${BROKEN:U:M*}
> PKG_FAIL_REASON+=       "${PKGNAME} is marked as broken:"
> PKG_FAIL_REASON+=       ${BROKEN}
> .  endif

My impression was that packages marked as BROKEN are expected
to be able to be fixed, while PKG_FAIL_REASON doesn't imply that.
Was I mistaken?

> -- 
> David A. Holland
> dholland%netbsd.org@localhost