pkgsrc-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Patch for ham/tnt



Can you create a proper patchfile?  Basically

   install pkgdiff

   make patch

   Modify src/file.c as neeeded, with pkgvi, or really just make sure
   the original version is file.c.orig.  Add comments that should be
   part of the code, as if you are submitting the change upstream, but
   if it's just fixing wrong code that should have been the new way all
   along, doesn't need a comment.  Don't add comments that say why you
   changed it.

   mkdir -p patches # create if doesn't exist

   mkpatches

   check that patches/patch-src-file.c or whatever is created is a clean
   diff, changing what is needed and not having any unnecesary changes.

   Edit patchfile to explain why the patch is needed.  Can be super
   brief, like "Add missing check for NULL pointer." if that's what it
   is.  This is what would be the upstream commit message.  File an
   upstream bug if the bugtracker works, even if nobody is home, and
   include the URL, or say that there is no place it could be filed.

   make distinfo

   make clean

   make package

Then you can send me the patchfile, and I'll add it and PKGREVISION++.

If this gets into also changing HOMEPAGE, or more rototilling to
generally improve it (which is a fine thing to do), then please get
access to wip and stage the new version of the package there, which
makes it easier to review/help.  Also wip packages should have
COMMIT_MSG, so someone with commit access can just bring the files back
and 'cvs commit -F COMMIT_MSG'.


Home | Main Index | Thread Index | Old Index