pkgsrc-WIP-changes archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
edbrowse: add a patch to avoid NULL pointer dereference.
Module Name: pkgsrc-wip
Committed By: Leonardo Taccari <leot%NetBSD.org@localhost>
Pushed By: leot
Date: Tue Jan 5 13:42:07 2016 +0100
Changeset: 01f2586de1d04f097376335eb30760012a5766db
Modified Files:
edbrowse/distinfo
Added Files:
edbrowse/patches/patch-src_buffers.c
Log Message:
edbrowse: add a patch to avoid NULL pointer dereference.
The bug is triggerable via just invoking edbrowse and then
(where ^D represents the EOF character):
rl
^D
XXX: I should notify upstream.
To see a diff of this commit:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=01f2586de1d04f097376335eb30760012a5766db
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
diffstat:
edbrowse/distinfo | 1 +
edbrowse/patches/patch-src_buffers.c | 16 ++++++++++++++++
2 files changed, 17 insertions(+)
diffs:
diff --git a/edbrowse/distinfo b/edbrowse/distinfo
index dff8af7..739ecdb 100644
--- a/edbrowse/distinfo
+++ b/edbrowse/distinfo
@@ -4,3 +4,4 @@ SHA1 (edbrowse-3.6.0.1.zip) = 9c4f158bd1492ac216a6f80e32143c2955910327
RMD160 (edbrowse-3.6.0.1.zip) = 6ecc8f955bededac87e8976f10aa7b92bd5194f1
SHA512 (edbrowse-3.6.0.1.zip) = b06b0631fd6305631abf57b5d6a7b51233cea51b4d02f92235d350872095a010e5982d5478f4a344d2e6c9e87fbae037880f34ef29aaa6cdc8c4da78089fc308
Size (edbrowse-3.6.0.1.zip) = 582275 bytes
+SHA1 (patch-src_buffers.c) = bbadde0840e88b6e345701cc0db6257f51a34a19
diff --git a/edbrowse/patches/patch-src_buffers.c b/edbrowse/patches/patch-src_buffers.c
new file mode 100644
index 0000000..5dfefa0
--- /dev/null
+++ b/edbrowse/patches/patch-src_buffers.c
@@ -0,0 +1,16 @@
+$NetBSD$
+
+Avoid possible NULL dereference typing a line with just an EOF character
+(typically via ^D).
+
+--- src/buffers.c.orig 2015-12-26 19:31:45.000000000 +0000
++++ src/buffers.c
+@@ -408,7 +408,7 @@ dotimers:
+
+ if (inputReadLine && isInteractive) {
+ last_rl = readline("");
+- if (*last_rl)
++ if ((last_rl != NULL) && *last_rl)
+ add_history(last_rl);
+ s = (uchar *) last_rl;
+ } else {
Home |
Main Index |
Thread Index |
Old Index