pkgsrc-WIP-changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

gqrx: Adjust dependencies



Module Name:	pkgsrc-wip
Committed By:	Greg Troxel <gdt%lexort.com@localhost>
Pushed By:	gdt
Date:		Tue Jul 26 23:32:05 2016 +0000
Changeset:	cf51865ed7a6e1a6dc328c310ed927eaaaafa26e

Modified Files:
	gqrx/Makefile
	gqrx/TODO

Log Message:
gqrx: Adjust dependencies

Drop gnuradio-utils.  List which gnuradio blocks are in which packages.
Add all 6 upstream-recommended hardware-support packages.
Add pulseaudio.
Give up on qt4, following upstream's editing of README.md and
recommendation to use qt5.

To see a diff of this commit:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=cf51865ed7a6e1a6dc328c310ed927eaaaafa26e

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

diffstat:
 gqrx/Makefile | 34 ++++++++++++++++++++++++++++++----
 gqrx/TODO     |  8 +-------
 2 files changed, 31 insertions(+), 11 deletions(-)

diffs:
diff --git a/gqrx/Makefile b/gqrx/Makefile
index d86ddee..48a9c1c 100644
--- a/gqrx/Makefile
+++ b/gqrx/Makefile
@@ -19,16 +19,42 @@ WRKSRC=		${WRKDIR}/gqrx-sdr-${VERSION}
 USE_CMAKE=	yes
 USE_LANGUAGES=	c c++
 
+## These dependencies are organized according to upstream's README
+## at https://github.com/csete/gqrx rather than alphabetically.
+
+# upstream's README.md does not document a dependency on boost libraries,
+# probably because gnuradio-core depends on boost, but there is one.
 .include "../../devel/boost-libs/buildlink3.mk"
+
+# Upstream documents needing multiple gnuradio blocks.  These do not
+# obviously correspond to pkgsrc split package names, so we list the
+# required blocks ahead of each gnuradio split package.
+# core has runtime, analog, audio, blocks, fft, filter, pmt
 .include "../../ham/gnuradio-core/buildlink3.mk"
+# digital has digital
 .include "../../ham/gnuradio-digital/buildlink3.mk"
-.include "../../ham/gnuradio-utils/buildlink3.mk"
+
+# gr-iqbalance (optional) - not in pkgsrc
+
+# These are drivers for particular hardware.  They are smallish and
+# therefore not optional.  (Also, gr-osmosdr depends on them, so
+# avoiding dependencies would not save space.)
+.include "../../ham/gnuradio-fcd/buildlink3.mk"
+.include "../../ham/gnuradio-uhd/buildlink3.mk"
+.include "../../ham/gr-fcdproplus/buildlink3.mk"
+.include "../../ham/rtl-sdr/buildlink3.mk"
+.include "../../ham/osmo-sdr/buildlink3.mk"
+.include "../../ham/hackrf/buildlink3.mk"
+
 .include "../../ham/gr-osmosdr/buildlink3.mk"
-#.include "../../ham/rtl-sdr/buildlink3.mk"
+.include "../../audio/pulseaudio/buildlink3.mk"
 
-# Upstream documents >=4.7, but with qt4-libs CMake complains that qt5
-# is not found.
+# Upstream documents that with qmake, 4.8 is needed, but the cmake
+# build requires qt5.  Upstream also outright recommends qt5.
 .include "../../x11/qt5-qtbase/buildlink3.mk"
 .include "../../x11/qt5-qtsvg/buildlink3.mk"
 
 .include "../../mk/bsd.pkg.mk"
+
+# Pointers to other packaging systems:
+# https://www.freshports.org/comms/gqrx/
diff --git a/gqrx/TODO b/gqrx/TODO
index 380d8d6..9e6ffd4 100644
--- a/gqrx/TODO
+++ b/gqrx/TODO
@@ -1,9 +1,3 @@
-* Figure out why qt5 is required but the README.md says that 4.7+ is
-  sufficient.  File bug upstream.
-
-* Figure out why boost is required and file bug upstream.
-
-* Figure out if this should depend on multiple hardware backends
-  directly, or if there should be more.
+* File bug upstream (or fix the README) about the boost requirement.
 
 * test


Home | Main Index | Thread Index | Old Index