zathura-pdf-mupdf: update comments to the patches and TODO

To: pkgsrc-wip-changes%NetBSD.org@localhost
Subject: zathura-pdf-mupdf: update comments to the patches and TODO
From: Leonardo Taccari <leot%NetBSD.org@localhost>
Date: Thu, 24 Nov 2016 11:43:03 +0000
Module Name:	pkgsrc-wip
Committed By:	Leonardo Taccari <leot%NetBSD.org@localhost>
Pushed By:	leot
Date:		Thu Nov 24 12:43:03 2016 +0100
Changeset:	c41e9a8f08f870421376f219ae00d678603df9ae

Modified Files:
	zathura-pdf-mupdf/TODO
	zathura-pdf-mupdf/distinfo
	zathura-pdf-mupdf/patches/patch-document.c
	zathura-pdf-mupdf/patches/patch-image.c
	zathura-pdf-mupdf/patches/patch-index.c
	zathura-pdf-mupdf/patches/patch-links.c
	zathura-pdf-mupdf/patches/patch-page.c
	zathura-pdf-mupdf/patches/patch-plugin.h
	zathura-pdf-mupdf/patches/patch-render.c
	zathura-pdf-mupdf/patches/patch-search.c
	zathura-pdf-mupdf/patches/patch-utils.c

Log Message:
zathura-pdf-mupdf: update comments to the patches and TODO

- Update comments to the patches to reflect current reality
- Add various TODO notes regarding regression introduced that need to be
  investigated further

To see a diff of this commit:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=c41e9a8f08f870421376f219ae00d678603df9ae

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

diffstat:
 zathura-pdf-mupdf/TODO                     |  9 ++++++++-
 zathura-pdf-mupdf/distinfo                 | 18 +++++++++---------
 zathura-pdf-mupdf/patches/patch-document.c |  2 +-
 zathura-pdf-mupdf/patches/patch-image.c    |  2 +-
 zathura-pdf-mupdf/patches/patch-index.c    |  2 ++
 zathura-pdf-mupdf/patches/patch-links.c    |  4 +++-
 zathura-pdf-mupdf/patches/patch-page.c     |  2 +-
 zathura-pdf-mupdf/patches/patch-plugin.h   |  2 +-
 zathura-pdf-mupdf/patches/patch-render.c   |  2 ++
 zathura-pdf-mupdf/patches/patch-search.c   |  2 +-
 zathura-pdf-mupdf/patches/patch-utils.c    |  2 +-
 11 files changed, 30 insertions(+), 17 deletions(-)

diffs:
diff --git a/zathura-pdf-mupdf/TODO b/zathura-pdf-mupdf/TODO
index 135c64e..fe37c45 100644
--- a/zathura-pdf-mupdf/TODO
+++ b/zathura-pdf-mupdf/TODO
@@ -1 +1,8 @@
-- Review patches and add comments to them
+Everything seems working but there are probably new regression due to 1.10 API
+migration that needs to be further investigated in order to update
+print/zathura-pdf-mupdf:
+
+- Gtk-WARNING **: Allocating size to zathura [address] without calling
+  gtk_widget_get_preferred_width/height().  How does the code know the size to
+  allocate?
+- warning: dropping unclosed device [probably related to the `search' command]
diff --git a/zathura-pdf-mupdf/distinfo b/zathura-pdf-mupdf/distinfo
index dceafdf..16fe0c4 100644
--- a/zathura-pdf-mupdf/distinfo
+++ b/zathura-pdf-mupdf/distinfo
@@ -4,12 +4,12 @@ SHA1 (zathura-pdf-mupdf-0.3.0.tar.gz) = ae0be41ea7c75b8ddc083fe01f1366673ea9751a
 RMD160 (zathura-pdf-mupdf-0.3.0.tar.gz) = 377e7848a5ea7f43f020e131aacc24c51453bf8f
 SHA512 (zathura-pdf-mupdf-0.3.0.tar.gz) = c83eef453176c6317be338260e311c39e049b8ae1ae719445c6303725b4e993758ed3f3a61f0af31032d09f1f2f03574f862d24e36b27fa38732e0b6c7aa18ea
 Size (zathura-pdf-mupdf-0.3.0.tar.gz) = 9914 bytes
-SHA1 (patch-document.c) = 0693cf6b52083383115e74a002e054d42d37389e
-SHA1 (patch-image.c) = 6f55a31ac3426af5ce312c86530400a6057c9a28
-SHA1 (patch-index.c) = 86f18b26a8c595dbc753d07a2dab3f6b0aed94da
-SHA1 (patch-links.c) = 9496fc74e480afd6c428835c7e1c90256e11737a
-SHA1 (patch-page.c) = f12d6e3e1ed2d1a59975d1f87becfdb64dc5813b
-SHA1 (patch-plugin.h) = 4ec3e1510938f4bf7c10194ee7702666b1e18eb9
-SHA1 (patch-render.c) = b484908e3f6ae6be377ad765f7bad9c0361e4d19
-SHA1 (patch-search.c) = 312d29bd2463df3bbbe4410f5f5fad07f9f04b93
-SHA1 (patch-utils.c) = 8b669ff734e94d6a248431a01d490efebb1b981a
+SHA1 (patch-document.c) = ed5a34515767482b83c9cb3f3a20d1c492a80307
+SHA1 (patch-image.c) = 15e60ede84c3b9a5f4d9b927bb5572c78a4409c3
+SHA1 (patch-index.c) = 8ec60bb5965abbc9d91be63305bf6b5a5244b30c
+SHA1 (patch-links.c) = 9e133625f5c45a9dd490d15bd19ae3529999a990
+SHA1 (patch-page.c) = bc3bd7325f4005986182949c5e66b1ee3040431b
+SHA1 (patch-plugin.h) = 8b12c096d265b397ae9f3a8aee7057a23dea3def
+SHA1 (patch-render.c) = c65ec3d6e9622149d987798b69c680c886b7f970
+SHA1 (patch-search.c) = 1cbed6cc8a8cf672e6330bd2e91e0976f90bc352
+SHA1 (patch-utils.c) = f27a00e812133b93fbdd7922906c091d78412138
diff --git a/zathura-pdf-mupdf/patches/patch-document.c b/zathura-pdf-mupdf/patches/patch-document.c
index 04cc9a4..5654fd9 100644
--- a/zathura-pdf-mupdf/patches/patch-document.c
+++ b/zathura-pdf-mupdf/patches/patch-document.c
@@ -1,7 +1,7 @@
 $NetBSD: patch-document.c,v 1.2 2016/04/27 12:38:45 leot Exp $
 
 o Correct the glib-2.0 include header file path.
-o Update to mupdf-1.9 API
+o Update to mupdf-1.10 API
 
 --- document.c.orig	2016-02-14 22:49:46.000000000 +0000
 +++ document.c
diff --git a/zathura-pdf-mupdf/patches/patch-image.c b/zathura-pdf-mupdf/patches/patch-image.c
index 0b4184f..ff798e4 100644
--- a/zathura-pdf-mupdf/patches/patch-image.c
+++ b/zathura-pdf-mupdf/patches/patch-image.c
@@ -1,6 +1,6 @@
 $NetBSD: patch-image.c,v 1.1 2016/04/27 12:38:45 leot Exp $
 
-Update to mupdf-1.9 API.
+Update to mupdf-1.10 API.
 
 --- image.c.orig	2016-02-14 22:49:46.000000000 +0000
 +++ image.c
diff --git a/zathura-pdf-mupdf/patches/patch-index.c b/zathura-pdf-mupdf/patches/patch-index.c
index 6561b3d..78655c8 100644
--- a/zathura-pdf-mupdf/patches/patch-index.c
+++ b/zathura-pdf-mupdf/patches/patch-index.c
@@ -1,5 +1,7 @@
 $NetBSD$
 
+Update to mupdf-1.10 API.
+
 --- index.c.orig	2016-02-14 22:49:46.000000000 +0000
 +++ index.c
 @@ -6,7 +6,7 @@
diff --git a/zathura-pdf-mupdf/patches/patch-links.c b/zathura-pdf-mupdf/patches/patch-links.c
index 1dbca0e..59932a2 100644
--- a/zathura-pdf-mupdf/patches/patch-links.c
+++ b/zathura-pdf-mupdf/patches/patch-links.c
@@ -1,5 +1,7 @@
 $NetBSD$
 
+Update to mupdf-1.10 API.
+
 --- links.c.orig	2016-02-14 22:49:46.000000000 +0000
 +++ links.c
 @@ -44,48 +44,22 @@ pdf_page_links_get(zathura_page_t* page,
@@ -57,7 +59,7 @@ $NetBSD$
 -        break;
 -      default:
 -        continue;
-+	target.page_number = fz_resolve_link(mupdf_document->ctx, mupdf_document->document, link->uri, &tx, &ty);
++        target.page_number = fz_resolve_link(mupdf_document->ctx, mupdf_document->document, link->uri, &tx, &ty);
 +        target.left             = tx;
 +        target.top              = ty;
      }
diff --git a/zathura-pdf-mupdf/patches/patch-page.c b/zathura-pdf-mupdf/patches/patch-page.c
index e66f038..56db594 100644
--- a/zathura-pdf-mupdf/patches/patch-page.c
+++ b/zathura-pdf-mupdf/patches/patch-page.c
@@ -1,6 +1,6 @@
 $NetBSD: patch-page.c,v 1.1 2016/04/27 12:38:45 leot Exp $
 
-Update to mupdf-1.9 API.
+Update to mupdf-1.10 API.
 
 --- page.c.orig	2016-02-14 22:49:46.000000000 +0000
 +++ page.c
diff --git a/zathura-pdf-mupdf/patches/patch-plugin.h b/zathura-pdf-mupdf/patches/patch-plugin.h
index e7b7483..2a6c80e 100644
--- a/zathura-pdf-mupdf/patches/patch-plugin.h
+++ b/zathura-pdf-mupdf/patches/patch-plugin.h
@@ -1,6 +1,6 @@
 $NetBSD: patch-plugin.h,v 1.1 2016/04/27 12:38:45 leot Exp $
 
-Update to mupdf-1.9 API.
+Update to mupdf-1.10 API.
 
 --- plugin.h.orig	2016-02-14 22:49:46.000000000 +0000
 +++ plugin.h
diff --git a/zathura-pdf-mupdf/patches/patch-render.c b/zathura-pdf-mupdf/patches/patch-render.c
index 613a0d0..ddaf2ec 100644
--- a/zathura-pdf-mupdf/patches/patch-render.c
+++ b/zathura-pdf-mupdf/patches/patch-render.c
@@ -1,5 +1,7 @@
 $NetBSD$
 
+Update to mupdf-1.10 API.
+
 --- render.c.orig	2016-02-14 22:49:46.000000000 +0000
 +++ render.c
 @@ -20,7 +20,10 @@ pdf_page_render_to_buffer(mupdf_document
diff --git a/zathura-pdf-mupdf/patches/patch-search.c b/zathura-pdf-mupdf/patches/patch-search.c
index b4cecea..1e6d011 100644
--- a/zathura-pdf-mupdf/patches/patch-search.c
+++ b/zathura-pdf-mupdf/patches/patch-search.c
@@ -1,6 +1,6 @@
 $NetBSD: patch-search.c,v 1.1 2016/04/27 12:38:45 leot Exp $
 
-Update to mupdf-1.9 API.
+Update to mupdf-1.10 API.
 
 --- search.c.orig	2016-02-14 22:49:46.000000000 +0000
 +++ search.c
diff --git a/zathura-pdf-mupdf/patches/patch-utils.c b/zathura-pdf-mupdf/patches/patch-utils.c
index 08e83fd..cc235ca 100644
--- a/zathura-pdf-mupdf/patches/patch-utils.c
+++ b/zathura-pdf-mupdf/patches/patch-utils.c
@@ -1,6 +1,6 @@
 $NetBSD: patch-utils.c,v 1.1 2016/04/27 12:38:45 leot Exp $
 
-Update to mupdf-1.9 API.
+Update to mupdf-1.10 API.
 
 --- utils.c.orig	2016-02-14 22:49:46.000000000 +0000
 +++ utils.c
Prev by Date: mupdf: Import mupdf-1.10 as wip/mupdf
Next by Date: (doxygen-depend/Makefile) Minor adjustment manually (hint: arrow.png)
Previous by Thread: mupdf: Import mupdf-1.10 as wip/mupdf
Next by Thread: (doxygen-depend/Makefile) Minor adjustment manually (hint: arrow.png)
Indexes:
Home | Main Index | Thread Index | Old Index