pkgsrc-WIP-changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: mk/git-package.mk: optimize for single-repository case



On 25.02.2018 16:33, Roland Illig wrote:
> Module Name:	pkgsrc-wip
> Committed By:	Roland Illig <rillig%NetBSD.org@localhost>
> Pushed By:	rillig
> Date:		Sun Feb 25 15:33:29 2018 +0000
> Changeset:	0d8eff801efb0033ed5b5ce77bc8a5509ba5d0c5
> 
> Modified Files:
> 	mk/git-package.mk
> 
> Log Message:
> mk/git-package.mk: optimize for single-repository case
> 
> In the majority of cases, a package corresponds to a single Git
> repository. Therefore, having three separate lines in the package
> Makefile is only overhead. The only line that such a package needs is
> 
>     GIT_REPO=       git://git%github.com@localhost/NetBSD/pkgsrc
> 
> This automatically sets GIT_REPOSITORIES, GIT_MODULE and WRKSRC.
> 
> This change is completely backwards-compatible, allowing the affected
> packages to be migrated on a case-to-case basis.
> 

Perfect, I've already discussed this with Thomas Klausner. This approach
is more BSD-style friendly, compared to examples like "PROG=cat" in
src/bin/cat/Makefile.

Could you please backport it to fossil, hg, cvs and svn .mk frameworks
as well?


Attachment: signature.asc
Description: OpenPGP digital signature



Home | Main Index | Thread Index | Old Index