vlc: pkglint

[Kamil Rytarowski <n54%gmx.com@localhost>]

Module Name:	pkgsrc-wip
Committed By:	Kamil Rytarowski <n54%gmx.com@localhost>
Pushed By:	kamil
Date:		Tue Mar 20 18:55:54 2018 +0100
Changeset:	bad1a39fbdd8092aefd7b4cc03aac6e7b7684a75

Modified Files:
	vlc/PLIST
	vlc/distinfo
	vlc/patches/patch-compat_Makefile.am
	vlc/patches/patch-include_vlc__common.h
	vlc/patches/patch-lib_core.c
	vlc/patches/patch-lib_video.c
	vlc/patches/patch-m4_dolt.m4
	vlc/patches/patch-modules_access_http_Makefile.am
	vlc/patches/patch-modules_codec_x264.c
	vlc/patches/patch-share_Makefile.am

Log Message:
vlc: pkglint

To see a diff of this commit:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=bad1a39fbdd8092aefd7b4cc03aac6e7b7684a75

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

diffstat:
 vlc/PLIST                                         |  2 --
 vlc/distinfo                                      | 16 ++++++++--------
 vlc/patches/patch-compat_Makefile.am              |  3 +++
 vlc/patches/patch-include_vlc__common.h           |  3 +++
 vlc/patches/patch-lib_core.c                      |  2 ++
 vlc/patches/patch-lib_video.c                     |  2 ++
 vlc/patches/patch-m4_dolt.m4                      |  3 +++
 vlc/patches/patch-modules_access_http_Makefile.am |  2 ++
 vlc/patches/patch-modules_codec_x264.c            |  2 ++
 vlc/patches/patch-share_Makefile.am               |  2 ++
 10 files changed, 27 insertions(+), 10 deletions(-)

diffs:
diff --git a/vlc/PLIST b/vlc/PLIST
index dd2b2a5f4a..886dca0004 100644
--- a/vlc/PLIST
+++ b/vlc/PLIST
@@ -337,9 +337,7 @@ lib/vlc/plugins/keystore/libmemory_keystore_plugin.la
 lib/vlc/plugins/logger/libconsole_logger_plugin.la
 lib/vlc/plugins/logger/libfile_logger_plugin.la
 lib/vlc/plugins/logger/libsyslog_plugin.la
-lib/vlc/plugins/lua/liblua_plugin.a
 lib/vlc/plugins/lua/liblua_plugin.la
-lib/vlc/plugins/lua/liblua_plugin.so
 lib/vlc/plugins/meta_engine/libfolder_plugin.la
 lib/vlc/plugins/meta_engine/libtaglib_plugin.la
 lib/vlc/plugins/misc/libaddonsfsstorage_plugin.la
diff --git a/vlc/distinfo b/vlc/distinfo
index b50322e4bd..c093cff14e 100644
--- a/vlc/distinfo
+++ b/vlc/distinfo
@@ -4,11 +4,11 @@ SHA1 (vlc-3.0.1.tar.xz) = 9eab63eeb525f200220fe7f99ca2a67805058517
 RMD160 (vlc-3.0.1.tar.xz) = b0ecf5e2bccb916d5e0fb8fa57593ae8c5ec7741
 SHA512 (vlc-3.0.1.tar.xz) = f2ba7586e8fb8c04484e62809265ec998e875b1eff03262bbf463370277a318816cbb8d260901c774e59443393b16b040cb714019c80e051578008abbf91b13c
 Size (vlc-3.0.1.tar.xz) = 25174040 bytes
-SHA1 (patch-compat_Makefile.am) = 8a5f9c82a748542423172a3a32daefd386ae815d
-SHA1 (patch-include_vlc__common.h) = cc5b766e882097f5a7767023e440e4ccd49b219f
-SHA1 (patch-lib_core.c) = 8033ccd21866271110ecbd7ce53345bf92c7371e
-SHA1 (patch-lib_video.c) = 6d6b46f46bc103a7548bf1dae84e76b57ba7aa5d
-SHA1 (patch-m4_dolt.m4) = f567605ca51069a681516016066ef0009787c904
-SHA1 (patch-modules_access_http_Makefile.am) = 1c28d851d4aae5007dc89511975d9c9f1c39c944
-SHA1 (patch-modules_codec_x264.c) = 7fd2fd2801b4a4f35e67bca8766b42a17528d503
-SHA1 (patch-share_Makefile.am) = d0b31ec5414382dbf93456bdeb24c1069d21f1d3
+SHA1 (patch-compat_Makefile.am) = b37232bbcac799b9920189acb475c64552b15001
+SHA1 (patch-include_vlc__common.h) = e78af2312315b7771715ab6697ba03122bcba6d3
+SHA1 (patch-lib_core.c) = 8ec5557424e6ddc05cc365aacd1ec847d9a94605
+SHA1 (patch-lib_video.c) = 362aaf7977c264bb70a79e98cf18da923ae62e39
+SHA1 (patch-m4_dolt.m4) = a1aac0c1021001a489f9b515e218904e065ed659
+SHA1 (patch-modules_access_http_Makefile.am) = d91904c6cba1a75a6872d042e4fe87ed9ce65a22
+SHA1 (patch-modules_codec_x264.c) = 8dc705fa1c87218a3bb8b8e39623886f08c725b2
+SHA1 (patch-share_Makefile.am) = 380dc4ac4a1a19cd1ccc8219b3d1d3b927585c49
diff --git a/vlc/patches/patch-compat_Makefile.am b/vlc/patches/patch-compat_Makefile.am
index fe3efd210e..b619868c99 100644
--- a/vlc/patches/patch-compat_Makefile.am
+++ b/vlc/patches/patch-compat_Makefile.am
@@ -1,5 +1,8 @@
 $NetBSD$
 
+libcompat must be prebuilt with PIC properties in order to be linked
+into PIC libraries.
+
 --- compat/Makefile.am.orig	2017-11-24 15:29:17.000000000 +0000
 +++ compat/Makefile.am
 @@ -1,7 +1,7 @@
diff --git a/vlc/patches/patch-include_vlc__common.h b/vlc/patches/patch-include_vlc__common.h
index c063383290..a3c5a20525 100644
--- a/vlc/patches/patch-include_vlc__common.h
+++ b/vlc/patches/patch-include_vlc__common.h
@@ -1,5 +1,8 @@
 $NetBSD$
 
+Backport patch merged upstream: disable bswap* and popcount*
+functions for NetBSD, as they are part of libc.
+
 --- include/vlc_common.h.orig	2017-12-21 09:51:16.000000000 +0000
 +++ include/vlc_common.h
 @@ -556,6 +556,7 @@ static inline unsigned (ctz)(unsigned x)
diff --git a/vlc/patches/patch-lib_core.c b/vlc/patches/patch-lib_core.c
index 39c2098234..d065e5c9f9 100644
--- a/vlc/patches/patch-lib_core.c
+++ b/vlc/patches/patch-lib_core.c
@@ -1,5 +1,7 @@
 $NetBSD$
 
+For unknown reason disable duplicated symbol for vlc_module_name.
+
 --- lib/core.c.orig	2017-11-24 15:29:17.000000000 +0000
 +++ lib/core.c
 @@ -257,4 +257,4 @@ int64_t libvlc_clock(void)
diff --git a/vlc/patches/patch-lib_video.c b/vlc/patches/patch-lib_video.c
index ac81154df6..2e3bd98135 100644
--- a/vlc/patches/patch-lib_video.c
+++ b/vlc/patches/patch-lib_video.c
@@ -1,5 +1,7 @@
 $NetBSD$
 
+Remove undefined references to missing symbol.
+
 --- lib/video.c.orig	2017-11-24 15:29:17.000000000 +0000
 +++ lib/video.c
 @@ -719,7 +719,7 @@ static int get_filter_str( vlc_object_t 
diff --git a/vlc/patches/patch-m4_dolt.m4 b/vlc/patches/patch-m4_dolt.m4
index 3cdbd7de9b..5257c4b1f9 100644
--- a/vlc/patches/patch-m4_dolt.m4
+++ b/vlc/patches/patch-m4_dolt.m4
@@ -1,5 +1,8 @@
 $NetBSD$
 
+Add NetBSD to dolt.m4. The fallback using libtool does not work
+correctly.
+
 --- m4/dolt.m4.orig	2017-11-24 15:29:17.000000000 +0000
 +++ m4/dolt.m4
 @@ -20,6 +20,7 @@ AS_IF([test x$GCC != xyes], [dolt_suppor
diff --git a/vlc/patches/patch-modules_access_http_Makefile.am b/vlc/patches/patch-modules_access_http_Makefile.am
index 51907421d9..bb95705365 100644
--- a/vlc/patches/patch-modules_access_http_Makefile.am
+++ b/vlc/patches/patch-modules_access_http_Makefile.am
@@ -1,5 +1,7 @@
 $NetBSD$
 
+Remove doubled symbols in libcompat in the vlc_http module.
+
 --- modules/access/http/Makefile.am.orig	2017-11-24 15:29:17.000000000 +0000
 +++ modules/access/http/Makefile.am
 @@ -16,7 +16,7 @@ libvlc_http_la_SOURCES = \
diff --git a/vlc/patches/patch-modules_codec_x264.c b/vlc/patches/patch-modules_codec_x264.c
index 82ea35180f..061cfc59e2 100644
--- a/vlc/patches/patch-modules_codec_x264.c
+++ b/vlc/patches/patch-modules_codec_x264.c
@@ -1,5 +1,7 @@
 $NetBSD$
 
+Disable X264 incompatible code for X264_BUILD >= 153.
+
 --- modules/codec/x264.c.orig	2017-11-29 23:35:29.000000000 +0000
 +++ modules/codec/x264.c
 @@ -842,7 +842,7 @@ static int  Open ( vlc_object_t *p_this 
diff --git a/vlc/patches/patch-share_Makefile.am b/vlc/patches/patch-share_Makefile.am
index b3ba3b365e..89aeadd87e 100644
--- a/vlc/patches/patch-share_Makefile.am
+++ b/vlc/patches/patch-share_Makefile.am
@@ -1,5 +1,7 @@
 $NetBSD$
 
+Remove unportable tar parameters.
+
 --- share/Makefile.am.orig	2018-02-06 18:41:06.000000000 +0000
 +++ share/Makefile.am
 @@ -94,7 +94,7 @@ skins2/default.vlt: $(skins2_default_vlt