Re: TODO: pick update was done

[Leonardo Taccari <leot%NetBSD.org@localhost>]

Hello Jenz!

Jenz Guenther writes:
> Module Name:	pkgsrc-wip
> Committed By:	Jenz Guenther <dbotw%gmx.net@localhost>
> Pushed By:	dbotw
> Date:		Mon May 7 20:17:52 2018 +0200
> Changeset:	539b8e1c213a7671978e7aaab09b21fdba28b1ce
>
> Added Files:
> 	pick/TODO
>
> Log Message:
> TODO: pick update was done

Cool! I think it is mostly ready to be imported, just mostly minor
cosmetic nitpicks! (no pun intended! :))

 - It seems that it also needs curses, so we need to include
   "../../mk/curses.buildlink3.mk"
 - At least NetBSD >= 8.0 (IIRC!) in order to use reallocarray(3) and
   strtonum(3) we need to add `-D_OPENBSD_SOURCE' via CFLAGS.
 - GITHUB_PROJECT is already by default PKGBASE (i.e. `pick') so we can
   safely avoid initialization of it

The attached patches does that and also add a comment to patch-curses
(I think it would be better to rename it to patch-pick.c to follow
the current pkgsrc practices).
Please let me know if I can commit them or feel free to commit them!

Then I think that we can import it!

And, a possible problem and probably the hardest one... this package
will conflict with at least the `pick' provided by mail/nmh.
From a quick skim to all the pick packages in the various package
systems linked in the HOMEPAGE it seems that never of them renamed it.
Would you like/do you think it would be a good idea to rename it or
would it be less confusing to just leave the conflict with nmh?


Thank you!

diff --git a/pick/Makefile b/pick/Makefile
index ee8db44c7d..b272e5ca00 100644
--- a/pick/Makefile
+++ b/pick/Makefile
@@ -3,7 +3,6 @@
 DISTNAME=	pick-2.0.2
 CATEGORIES=	sysutils
 MASTER_SITES=	${MASTER_SITE_GITHUB:=mptre/}
-GITHUB_PROJECT=	pick
 GITHUB_RELEASE=	v${PKGVERSION_NOREV}
 
 MAINTAINER=	dbotw%gmx.net@localhost
@@ -13,4 +12,7 @@ LICENSE=	mit
 
 GNU_CONFIGURE=	yes
 
+CFLAGS.NetBSD+=	-D_OPENBSD_SOURCE	# reallocarray(3), strtonum(3)
+
+.include "../../mk/curses.buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"
diff --git a/pick/distinfo b/pick/distinfo
index 6475cffa22..dc6b51b823 100644
--- a/pick/distinfo
+++ b/pick/distinfo
@@ -4,4 +4,4 @@ SHA1 (pick-2.0.2.tar.gz) = 6cc08e999f044defff085efa9182678cf25ff132
 RMD160 (pick-2.0.2.tar.gz) = 0d5b69ca295511ac7e32b3a8fea24c590ed089e3
 SHA512 (pick-2.0.2.tar.gz) = 92d74fa62f6c829117c6c3faf6ec39fc5dd66465516be396d21d7b0a92ee10761a1d3f43aa4a454f8d19790ac02a4a1af145139d488344c97a511805c5d6965b
 Size (pick-2.0.2.tar.gz) = 132174 bytes
-SHA1 (patch-curses) = a201bf7316b20656949a62617c3369a05e5b1778
+SHA1 (patch-curses) = cdce675828e0187cc9567aeec93893c9dbd14087
diff --git a/pick/patches/patch-curses b/pick/patches/patch-curses
index 907dfabd23..b3d2e32b69 100644
--- a/pick/patches/patch-curses
+++ b/pick/patches/patch-curses
@@ -1,5 +1,8 @@
 $NetBSD$
 
+tparm(3) expects a `const char *' as first argument, adjust tty_parm1()
+accordingly.
+
 --- pick.c.orig	2018-04-10 19:52:06.000000000 +0000
 +++ pick.c
 @@ -90,7 +90,7 @@ static void			 toggle_sigwinch(int);