Re: mblaze: Import mblaze-v0.3.2 as wip/mblaze

[Leonardo Taccari <leot%NetBSD.org@localhost>]

Hello Sunil,
thank you very much for packaging it!
Just some possible improvements in order to import it as mail/mblaze
(most of them are mostly cosmetic and/or nitpicks, the package
already look pretty good, nice work!)

Sunil Nimmagadda writes:
> [...]
> --- /dev/null
> +++ b/mblaze/Makefile
> @@ -0,0 +1,22 @@
> +# $NetBSD$
> +
> +GITHUB_PROJECT=	mblaze
> +DISTNAME=	v0.3.2
> +PKGNAME=	${GITHUB_PROJECT}-${DISTNAME}
> +CATEGORIES=	mail
> +MASTER_SITES=	${MASTER_SITE_GITHUB:=chneukirchen/}
> +DIST_SUBDIR=	${GITHUB_PROJECT}
> +

This can be simplified. GITHUB_PROJECT, DIST_SUBDIR and PKGNAME
can be deleted and just setting:

 DISTNAME=   mblaze-0.3.2
 [...]
 GITHUB_TAG= v${PKGVERSION_NOREV}

...should do the trick. This will also need a `make makesum' though
because the distfile name will be `mblaze-0.3.2.tar.gz'.

> [...]
> +WRKSRC=		${WRKDIR}/mblaze-0.3.2
> +

...and with the previous change also WRKSRC redefinition is no longer
needed!

> +NO_CONFIGURE=	yes
> +USE_TOOLS+=	gmake
> +MAKE_FILE=	GNUmakefile
> +MAKE_FLAGS+=	PREFIX=${PREFIX:Q} BINDIR=${PREFIX:Q}/bin MANDIR=${PREFIX:Q}/man
> +

At least on NetBSD we can not easily spot that but if I am reading
the GNUmakefile and grep-ing the source code correctly...  I think
that it is also needed to add a:

 .include "../../converters/libiconv/buildlink3.mk"

> +.include "../../mk/bsd.pkg.mk"
> [...]


Thank you!