webkit-gtk: Add WebKitWebProcess and jsc via NOT_PAX_MPROTECT_SAFE

[Leonardo Taccari <leot%NetBSD.org@localhost>]

Module Name:	pkgsrc-wip
Committed By:	Leonardo Taccari <leot%NetBSD.org@localhost>
Pushed By:	leot
Date:		Mon Oct 8 10:22:09 2018 +0200
Changeset:	dfa3fe75682f074a5ff1c97b01e4e8d61d168e84

Modified Files:
	webkit-gtk/Makefile
	webkit-gtk/TODO

Log Message:
webkit-gtk: Add WebKitWebProcess and jsc via NOT_PAX_MPROTECT_SAFE

At least on NetBSD/amd64, running SunSpider 1.0.2 JavaScript Benchmark
(<https://webkit.org/perf/sunspider/sunspider.html>) with MiniBrowser
and security.pax.mprotect.global=1 needed around:

 Total:                 1006.9ms +/- 0.7%

...while after temporary setting security.pax.mprotect.global=0:

 Total:                 322.3ms +/- 3.0%

(Probably EACCESS due PaX MPROTECT are handled gracefully and
silently instead of failing hard at runtime.)

Add WebKitWebProcess and jsc to NOT_PAX_MPROTECT_SAFE to obtain
the same.  Please also note that webkit-gtk browsers should not
need any NOT_PAX_MPROTECT_SAFE because WebKitWebProcess is used
and already had that.

To see a diff of this commit:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=dfa3fe75682f074a5ff1c97b01e4e8d61d168e84

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

diffstat:
 webkit-gtk/Makefile |  3 +++
 webkit-gtk/TODO     | 18 ------------------
 2 files changed, 3 insertions(+), 18 deletions(-)

diffs:
diff --git a/webkit-gtk/Makefile b/webkit-gtk/Makefile
index fbe748dd81..e9dd3c69d2 100644
--- a/webkit-gtk/Makefile
+++ b/webkit-gtk/Makefile
@@ -92,6 +92,9 @@ CXXFLAGS+=	-Wno-c++11-narrowing
 # This does not disable optimisations, merely avoids #error if there are none.
 CFLAGS+=	-DRELEASE_WITHOUT_OPTIMIZATIONS
 
+NOT_PAX_MPROTECT_SAFE+=	libexec/webkit2gtk-4.0/WebKitWebProcess
+NOT_PAX_MPROTECT_SAFE+=	libexec/webkit2gtk-4.0/jsc
+
 .include "options.mk"
 
 BUILDLINK_API_DEPENDS.glib2+= glib2>=2.32.1
diff --git a/webkit-gtk/TODO b/webkit-gtk/TODO
index 3d9b42ecc0..27e67bd818 100644
--- a/webkit-gtk/TODO
+++ b/webkit-gtk/TODO
@@ -1,21 +1,3 @@
-- On NetBSD/amd64, running SunSpider 1.0.2 JavaScript Benchmark
-  (<https://webkit.org/perf/sunspider/sunspider.html>) with MiniBrowser
-  and security.pax.mprotect.global=1:
-
-    Total:                 1006.9ms +/- 0.7%
-
-  ...while with security.pax.mprotect.global=0:
-
-    Total:                 322.3ms +/- 3.0%
-
-  Test if just adding:
-
-   NOT_PAX_MPROTECT_SAFE+= libexec/webkit2gtk-4.0/jsc
-   NOT_PAX_MPROTECT_SAFE+= libexec/webkit2gtk-4.0/WebKitWebProcess
-
-  leads to the same results.
-  (The webkit-gtk browsers probably don't need any NOT_PAX_MPROTECT_SAFE
-  because they use WebKitWebProcess)
 - Review JIT support for NetBSD:
    * patches/patch-Source_JavaScriptCore_runtime_MachineContext.h
    * patches/patch-Source_WTF_wtf_Platform.h