pkgsrc-WIP-changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

chicken5: Add support for tests



Module Name:	pkgsrc-wip
Committed By:	Leonardo Taccari <leot%NetBSD.org@localhost>
Pushed By:	leot
Date:		Sun Oct 14 15:30:32 2018 +0200
Changeset:	37f6f280d89fee11cf7ec3b17c46bedfd8d5ef34

Modified Files:
	chicken5/distinfo
Added Files:
	chicken5/patches/patch-tests_runtests.sh
Removed Files:
	chicken5/TODO

Log Message:
chicken5: Add support for tests

(Full details in patch-tests_runtests.sh, but TLDR: Always double
check to source (`.') the results of `export -p' because invalid
variable identifiers can be present!)

To see a diff of this commit:
https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=37f6f280d89fee11cf7ec3b17c46bedfd8d5ef34

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

diffstat:
 chicken5/TODO                            | 18 ------------------
 chicken5/distinfo                        |  1 +
 chicken5/patches/patch-tests_runtests.sh | 18 ++++++++++++++++++
 3 files changed, 19 insertions(+), 18 deletions(-)

diffs:
diff --git a/chicken5/TODO b/chicken5/TODO
deleted file mode 100644
index a817529acd..0000000000
--- a/chicken5/TODO
+++ /dev/null
@@ -1,18 +0,0 @@
-Tests fail because a invalid variable identifier is tried to be exported:
-
- | ===> Testing for chicken-5.0.0rc3
- | cd tests; sh runtests.sh
- | ======================================== repository search path ...
- | (/usr/pkg/lib/chicken/9)
- | (PASS) (repository-path) contains something by default
- |  TOTALS:
- |   1 tests completed in 0.272 seconds
- |   1 (100.00%) tests passed
- |   0 (0.00%) tests failed
- | export: .MAKE.LEVEL.ENV: bad variable name
-
-.MAKE.LEVEL.ENV is used internally by make(1) (not gmake!) and due the `.'
-it is not a valid identifier for shell variable, hence the corresponding
-export fails.
-
-This happens because `export -p' is used.
diff --git a/chicken5/distinfo b/chicken5/distinfo
index 1c88c05baf..1e6c31862a 100644
--- a/chicken5/distinfo
+++ b/chicken5/distinfo
@@ -4,3 +4,4 @@ SHA1 (chicken-5.0.0rc3.tar.gz) = 573a56320dbda9572a4895df937e1fd29527f526
 RMD160 (chicken-5.0.0rc3.tar.gz) = 40a4b5834c19129972f00e8c51cb3372c7c613db
 SHA512 (chicken-5.0.0rc3.tar.gz) = 14e6b8d9902486f534613b27f4c31eeadd8d018b090e2cb59bfea527e4fadfcf66c5ecc507d7178e4835889d34c41d633a124a8eac73222878339b50e6321d4b
 Size (chicken-5.0.0rc3.tar.gz) = 4002579 bytes
+SHA1 (patch-tests_runtests.sh) = c2bcee720a56cc399c6acdb1e002dbcd82ea272e
diff --git a/chicken5/patches/patch-tests_runtests.sh b/chicken5/patches/patch-tests_runtests.sh
new file mode 100644
index 0000000000..9d3dbc4e14
--- /dev/null
+++ b/chicken5/patches/patch-tests_runtests.sh
@@ -0,0 +1,18 @@
+$NetBSD$
+
+`export -p' also exports make(1) variables that contains `.', e.g.
+`.MAKE.ENV.LEVEL'.  As part of `. ./env.out' this lead to failure because
+variable with `.' are not valid is sh(1) context.
+Filter `export -p' output to avoid that.
+
+--- tests/runtests.sh.orig	2018-09-23 09:24:46.000000000 +0000
++++ tests/runtests.sh
+@@ -64,7 +64,7 @@ cp $TYPESDB test-repository/types.db
+ 
+ echo "======================================== repository search path ..."
+ if test -z "$MSYSTEM"; then
+-  export -p >./env.out
++  export -p | sed -ne '/export [^.]*=/p' >./env.out
+   unset CHICKEN_REPOSITORY_PATH
+   $interpret -s repository-path-default.scm
+   . ./env.out


Home | Main Index | Thread Index | Old Index